Bug 88945 – webkitpy: rework the TestExpectations style checker in preparation for the cascade

• Component: New Bugs
• Status: RESOLVED FIXED

[Dirk Pranke]

webkitpy: rework the TestExpectations style checker in preparation for the cascade

[Dirk Pranke]

Created attachment 147216 [details]
Patch

[Ojan Vafai]

Comment on attachment 147216 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=147216&action=review

> Tools/Scripts/webkitpy/style/checkers/test_expectations.py:82
> +        expectations = parser.parse('expectations', expectations_str)
> +        if overrides:
> +            expectations += parser.parse('overrides', overrides)

This should have a FIXME to handle cascading expectations properly.

I think each style error line should probably print out the file the style error is in.

[Dirk Pranke]

(In reply to comment #2)
> (From update of attachment 147216 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=147216&action=review
> 
> > Tools/Scripts/webkitpy/style/checkers/test_expectations.py:82
> > +        expectations = parser.parse('expectations', expectations_str)
> > +        if overrides:
> > +            expectations += parser.parse('overrides', overrides)
> 
> This should have a FIXME to handle cascading expectations properly.
> 
> I think each style error line should probably print out the file the style error is in.

Probably, but that'll require reworking this file further; right now the style checker just passes the string in so we don't even know the filename.

As a sidenote, I'm pretty sure the overrides flag is always False and isn't actually used. 

I'll add some comments, though. Thanks for the reviews!

[Dirk Pranke]

Committed r120238: <http://trac.webkit.org/changeset/120238>