Bug 88933

Summary: [Qt][Wk2] Support client time picker dialog
Product: WebKit Reporter: Dinu Jacob <dinu.jacob>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: cmarcelo, menard, pierre.rossi, webkit.review.bot, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 88026    
Bug Blocks:    
Attachments:
Description Flags
First patch
none
Patch
none
Patch with style fix
none
Style fix none

Description Dinu Jacob 2012-06-12 16:16:58 PDT
Add support for client time picker dialog for input element 'time'
Comment 1 Dinu Jacob 2012-06-12 16:25:08 PDT
Created attachment 147187 [details]
First patch
Comment 2 Dinu Jacob 2012-06-13 15:29:38 PDT
Created attachment 147426 [details]
Patch
Comment 3 WebKit Review Bot 2012-06-13 17:00:46 PDT
Attachment 147426 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/qt/ChangeLog', u'Source/WebK..." exit_code: 1
Source/WebKit2/UIProcess/qt/WebTimePickerProxyQt.h:26:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit2/UIProcess/qt/WebTimePickerProxyQt.h:27:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit2/UIProcess/qt/WebTimePickerProxyQt.h:53:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/UIProcess/qt/WebTimePickerProxyQt.cpp:22:  You should add a blank line after implementation file's own header.  [build/include_order] [4]
Source/WebKit2/UIProcess/qt/WebTimePickerProxyQt.cpp:24:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit2/UIProcess/qt/WebTimePickerProxyQt.cpp:26:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit2/UIProcess/qt/WebTimePickerProxyQt.cpp:119:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 7 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Dinu Jacob 2012-06-13 17:58:47 PDT
Created attachment 147453 [details]
Patch with style fix
Comment 5 WebKit Review Bot 2012-06-13 18:02:27 PDT
Attachment 147453 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/qt/ChangeLog', u'Source/WebK..." exit_code: 1
Source/WebKit2/UIProcess/qt/WebTimePickerProxyQt.h:26:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit2/UIProcess/qt/WebTimePickerProxyQt.h:27:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit2/UIProcess/qt/WebTimePickerProxyQt.h:53:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/UIProcess/qt/WebTimePickerProxyQt.cpp:22:  You should add a blank line after implementation file's own header.  [build/include_order] [4]
Source/WebKit2/UIProcess/qt/WebTimePickerProxyQt.cpp:24:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit2/UIProcess/qt/WebTimePickerProxyQt.cpp:26:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit2/UIProcess/qt/WebTimePickerProxyQt.cpp:119:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 7 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Dinu Jacob 2012-06-13 18:06:17 PDT
Created attachment 147456 [details]
Style fix

The right patch this time!!
Comment 7 Jocelyn Turcotte 2014-02-03 03:21:12 PST
=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.