Summary: | [CSS Regions] The regionLayoutUpdate event should be dispatched on the NamedFlow object | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andrei Bucur <abucur> | ||||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, eric, mihnea, ojan, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 87640 | ||||||||
Attachments: |
|
Description
Andrei Bucur
2012-06-11 06:39:14 PDT
Created attachment 152736 [details]
Patch
Comment on attachment 152736 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152736&action=review I didn't review the tests that carefully because I presume these are reworks of the tests you're removing. > Source/WebCore/ChangeLog:17 > + No new tests (OOPS!). This line will prevent the patch from landing. Can you update this to list the test that you've added? > Source/WebCore/dom/WebKitNamedFlow.h:65 > + virtual const AtomicString& interfaceName() const; > + virtual ScriptExecutionContext* scriptExecutionContext() const; We've been adding the OVERRIDE keyword to overrides of these functions. Created attachment 155812 [details]
Patch
Comment on attachment 155812 [details] Patch Clearing flags on attachment: 155812 Committed r124350: <http://trac.webkit.org/changeset/124350> All reviewed patches have been landed. Closing bug. |