Bug 88778 - [CSS Regions] The regionLayoutUpdate event should be dispatched on the NamedFlow object
Summary: [CSS Regions] The regionLayoutUpdate event should be dispatched on the NamedF...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 87640
  Show dependency tree / graph
 
Reported: 2012-06-11 06:39 PDT by Andrei Bucur
Modified: 2012-08-01 11:42 PDT (History)
5 users (show)

See Also:

Attachments
Patch (61.35 KB, patch)
2012-07-17 04:53 PDT, Andrei Bucur 		no flags Details | Formatted Diff | Diff
Patch (61.62 KB, patch)
2012-08-01 08:06 PDT, Andrei Bucur 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrei Bucur 2012-06-11 06:39:14 PDT 
The CSS Regions spec requests that the regionLayoutUpdate event be dispatched on the NamedFlow object, not on the attached regions.

http://www.w3.org/TR/css3-regions/#region-flow-layout-events
Comment 1 Andrei Bucur 2012-07-17 04:53:41 PDT 
Created attachment 152736 [details]
Patch
Comment 2 Adam Barth 2012-07-24 17:27:09 PDT 
Comment on attachment 152736 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=152736&action=review

I didn't review the tests that carefully because I presume these are reworks of the tests you're removing.

> Source/WebCore/ChangeLog:17
> +        No new tests (OOPS!).

This line will prevent the patch from landing.  Can you update this to list the test that you've added?

> Source/WebCore/dom/WebKitNamedFlow.h:65
> +    virtual const AtomicString& interfaceName() const;
> +    virtual ScriptExecutionContext* scriptExecutionContext() const;

We've been adding the OVERRIDE keyword to overrides of these functions.
Comment 3 Andrei Bucur 2012-08-01 08:06:16 PDT 
Created attachment 155812 [details]
Patch
Comment 4 WebKit Review Bot 2012-08-01 11:42:45 PDT 
Comment on attachment 155812 [details]
Patch

Clearing flags on attachment: 155812

Committed r124350: <http://trac.webkit.org/changeset/124350>
Comment 5 WebKit Review Bot 2012-08-01 11:42:49 PDT 
All reviewed patches have been landed.  Closing bug.