Summary: | remove ChromiumDriver from NRWT | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dirk Pranke <dpranke> | ||||
Component: | Tools / Tests | Assignee: | Xianzhu Wang <wangxianzhu> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, jnd, jochen, ojan, tony, wangxianzhu, webkit.review.bot, zhenghao | ||||
Priority: | P2 | Keywords: | NRWT | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 88542 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Dirk Pranke
2012-06-06 18:14:09 PDT
The chromium-android port does appear to be using --test-shell. I'm not sure what's involved in making it work without that flag. there's no real urgency on this change, but it might be nice to at least move the class over to reduce any potential confusion on the desktop side. *** Bug 86928 has been marked as a duplicate of this bug. *** resetting the owner in case someone else wants to take a look, as these bugs aren't on my immediate to-do list. (In reply to comment #5) > I'll do this after finishing bug 88542. > > Dirk, could you review the patch of bug 88542? Sure, posted comments there. Created attachment 152667 [details]
Patch
Comment on attachment 152667 [details]
Patch
yay!
Comment on attachment 152667 [details] Patch Clearing flags on attachment: 152667 Committed r122855: <http://trac.webkit.org/changeset/122855> All reviewed patches have been landed. Closing bug. @jochen: This is the patch I mentioned that removes support for test shell mode. Is there code in DumpRenderTree to delete now too? (In reply to comment #12) > Is there code in DumpRenderTree to delete now too? That's in bug 86927. |