Bug 88394

Summary: [Form] Changes for InputNumber type
Product: WebKit Reporter: yosin
Component: FormsAssignee: yosin
Status: RESOLVED FIXED    
Severity: Normal CC: tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 88383    
Attachments:
Description Flags
Patch 1 none

yosin
Reported 2012-06-05 23:51:48 PDT
On bug 88220, we introduced InputNumber type for reducing patch size of introducing Decimal type. Although, I forgot number of places to use InputNumber. We should fix this before introducing Decimal type.
Attachments
Patch 1 (7.07 KB, patch)
2012-06-06 00:44 PDT, yosin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
yosin
Comment 1 2012-06-06 00:44:31 PDT
Created attachment 145952 [details] Patch 1
yosin
Comment 2 2012-06-06 00:59:17 PDT
Comment on attachment 145952 [details] Patch 1 Could you review this patch? Thanks in advance. * Local build with enabling all input type on * To avoid including wtf/MathExtras.h for round in StepRange.h. roundByStep function is defined in StepRange.cpp. ** On Decimal, we don't need to include MathExtras.h to use round.
Kent Tamura
Comment 3 2012-06-06 01:55:56 PDT
Comment on attachment 145952 [details] Patch 1 ok
WebKit Review Bot
Comment 4 2012-06-06 03:26:36 PDT
Comment on attachment 145952 [details] Patch 1 Clearing flags on attachment: 145952 Committed r119580: <http://trac.webkit.org/changeset/119580>
WebKit Review Bot
Comment 5 2012-06-06 03:26:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.