Bug 88371

Summary: [chromium] Free texture from CCIOSurfaceLayerImpl when it is destroyed
Product: WebKit Reporter: Dana Jansens <danakj>
Component: New BugsAssignee: Dana Jansens <danakj>
Status: RESOLVED FIXED    
Severity: Normal CC: aelias, cc-bugs, enne, jamesr, kbr, piman, webkit.review.bot, wjmaclean
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 88584    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing webkit.review.bot: commit-queue-

Dana Jansens
Reported 2012-06-05 15:45:08 PDT
[chromium] Free texture from CCIOSurfaceLayerImpl when it is destroyed
Attachments
Patch (14.15 KB, patch)
2012-06-05 15:49 PDT, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Patch (8.52 KB, patch)
2012-06-05 15:57 PDT, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Patch for landing (11.47 KB, patch)
2012-06-08 18:26 PDT, Dana Jansens 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dana Jansens
Comment 1 2012-06-05 15:48:11 PDT
The one thing I wasn't sure about was returning a PassRefPtr<CCGraphicsContext> vs a CCGraphicsContext*. The latter requires storing a CCGraphicsContext permanently in LRC which maybe we want to do?
Dana Jansens
Comment 2 2012-06-05 15:49:13 PDT
Created attachment 145884 [details] Patch
Alexandre Elias
Comment 3 2012-06-05 15:51:59 PDT
The CCLayerTreeHostImpl already holds a CCGraphicsContext, so how about using that one instead of adding the method to CCRenderer?
Dana Jansens
Comment 4 2012-06-05 15:52:47 PDT
Ohh, I didn't see that one, thanks.
Dana Jansens
Comment 5 2012-06-05 15:57:06 PDT
Created attachment 145887 [details] Patch
Dana Jansens
Comment 6 2012-06-05 16:02:01 PDT
Well, I guess it depends if m_frame->planes() > 0. Maybe it's always 0 when a format with external texture is used?
Dana Jansens
Comment 7 2012-06-05 16:02:16 PDT
er.. wrong bug :(
Dana Jansens
Comment 8 2012-06-07 09:54:54 PDT
ping for review :)
James Robinson
Comment 9 2012-06-07 11:43:37 PDT
Comment on attachment 145887 [details] Patch R=me
WebKit Review Bot
Comment 10 2012-06-07 12:07:55 PDT
Comment on attachment 145887 [details] Patch Clearing flags on attachment: 145887 Committed r119744: <http://trac.webkit.org/changeset/119744>
WebKit Review Bot
Comment 11 2012-06-07 12:08:01 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 12 2012-06-07 15:30:45 PDT
Re-opened since this is blocked by 88584
Dana Jansens
Comment 13 2012-06-08 18:26:04 PDT
Created attachment 146676 [details] Patch for landing
WebKit Review Bot
Comment 14 2012-06-08 22:56:40 PDT
Comment on attachment 146676 [details] Patch for landing Rejecting attachment 146676 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: rce/WebCore/platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp patching file Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp Hunk #2 succeeded at 1725 (offset 100 lines). Hunk #3 succeeded at 1791 (offset 100 lines). Hunk #4 FAILED at 1711. 1 out of 4 hunks FAILED -- saving rejects to file Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12919707
Dana Jansens
Comment 15 2012-08-22 08:04:46 PDT
This was landed again but not closed.
Note You need to log in before you can comment on or make changes to this bug.