Bug 88279

Summary: webkitpy: perf tests unit tests fail on chromium win
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, jberlin, ojan, rniwa, simonjam, tonyg, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch rniwa: review+

Dirk Pranke
Reported 2012-06-04 19:02:24 PDT
webkitpy: perf tests unit tests fail on chromium win
Attachments
Patch (2.68 KB, patch)
2012-06-04 19:06 PDT, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
Patch (2.33 KB, patch)
2012-06-05 15:10 PDT, Dirk Pranke 		rniwa: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-06-04 19:06:06 PDT
Created attachment 145677 [details] Patch
Dirk Pranke
Comment 2 2012-06-04 19:06:59 PDT
*** Bug 88277 has been marked as a duplicate of this bug. ***
Dirk Pranke
Comment 3 2012-06-04 19:18:21 PDT
hm, interesting, these tests seem to pass on the bot: http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29/builds/26959/steps/webkitpy-test/logs/stdio
Jessie Berlin
Comment 4 2012-06-05 09:30:45 PDT
I also don't see them failing in the Apple Win stdio for the webkitpy tests: http://build.webkit.org/builders/Windows%207%20Release%20%28Tests%29/builds/24456/steps/webkitpy-test/logs/stdio
Dirk Pranke
Comment 5 2012-06-05 15:05:31 PDT
I'm still seeing weird failures in my configuration; I'm not sure why this isn't failing on the bots yet.
Dirk Pranke
Comment 6 2012-06-05 15:06:42 PDT
For now I'm going to skip the webpage replay import; the rest of the perf unit tests seem to run fine. And I'll add a message to run-perf-tests to just bail out on win32.
Dirk Pranke
Comment 7 2012-06-05 15:10:33 PDT
Created attachment 145878 [details] Patch
Dirk Pranke
Comment 8 2012-06-06 12:57:35 PDT
Committed r119604: <http://trac.webkit.org/changeset/119604>
Note You need to log in before you can comment on or make changes to this bug.