Bug 88279 - webkitpy: perf tests unit tests fail on chromium win
Summary: webkitpy: perf tests unit tests fail on chromium win
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
: 88277 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-06-04 19:02 PDT by Dirk Pranke
Modified: 2012-06-06 12:57 PDT (History)
7 users (show)

See Also:


Attachments
Patch (2.68 KB, patch)
2012-06-04 19:06 PDT, Dirk Pranke
no flags Details | Formatted Diff | Diff
Patch (2.33 KB, patch)
2012-06-05 15:10 PDT, Dirk Pranke
rniwa: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-06-04 19:02:24 PDT
webkitpy: perf tests unit tests fail on chromium win
Comment 1 Dirk Pranke 2012-06-04 19:06:06 PDT
Created attachment 145677 [details]
Patch
Comment 2 Dirk Pranke 2012-06-04 19:06:59 PDT
*** Bug 88277 has been marked as a duplicate of this bug. ***
Comment 3 Dirk Pranke 2012-06-04 19:18:21 PDT
hm, interesting, these tests seem to pass on the bot:

http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29/builds/26959/steps/webkitpy-test/logs/stdio
Comment 4 Jessie Berlin 2012-06-05 09:30:45 PDT
I also don't see them failing in the Apple Win stdio for the webkitpy tests: http://build.webkit.org/builders/Windows%207%20Release%20%28Tests%29/builds/24456/steps/webkitpy-test/logs/stdio
Comment 5 Dirk Pranke 2012-06-05 15:05:31 PDT
I'm still seeing weird failures in my configuration; I'm not sure why this isn't failing on the bots yet.
Comment 6 Dirk Pranke 2012-06-05 15:06:42 PDT
For now I'm going to skip the webpage replay import; the rest of the perf unit tests seem to run fine. And I'll add a message to run-perf-tests to just bail out on win32.
Comment 7 Dirk Pranke 2012-06-05 15:10:33 PDT
Created attachment 145878 [details]
Patch
Comment 8 Dirk Pranke 2012-06-06 12:57:35 PDT
Committed r119604: <http://trac.webkit.org/changeset/119604>