| Summary: | [Qt] Add a custom Color Chooser widget to MiniBrowser | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Thiago Marcos P. Santos <tmpsantos> | ||||||
| Component: | WebKit Qt | Assignee: | Thiago Marcos P. Santos <tmpsantos> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | hausmann, kenneth, menard, vestbo, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 87749 | ||||||||
| Bug Blocks: | 87989 | ||||||||
| Attachments: |
|
||||||||
|
Description
Thiago Marcos P. Santos
2012-05-31 10:26:15 PDT
Created attachment 145139 [details]
Patch
Comment on attachment 145139 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=145139&action=review Overall it's ok, the basic color picker is fine for testing :). Could you please fix the style? thanks > Tools/MiniBrowser/qt/qml/ColorChooser.qml:41 > + width: parent.width / 4 ; height: parent.height / 4 one statement per line and no ; needed then. > Tools/MiniBrowser/qt/qml/ColorChooser.qml:46 > + anchors.left: parent.left; anchors.top: parent.top same here. > Tools/MiniBrowser/qt/qml/ColorChooser.qml:48 > + width: parent.width / 2 - dialog.spacing; height: parent.height / 2 - dialog.spacing here. > Tools/MiniBrowser/qt/qml/ColorChooser.qml:60 > + width: parent.width / 2 - dialog.spacing; height: parent.height / 2 - dialog.spacing same here > Tools/MiniBrowser/qt/qml/ColorChooser.qml:70 > + anchors.bottom: parent.bottom; anchors.left: parent.left ditto > Tools/MiniBrowser/qt/qml/ColorChooser.qml:72 > + width: parent.width / 2 - dialog.spacing; height: parent.height / 2 - dialog.spacing ditto. > Tools/MiniBrowser/qt/qml/ColorChooser.qml:82 > + anchors.bottom: parent.bottom; anchors.right: parent.right ditto. Created attachment 148773 [details]
Patch v2
Updated patch addressing the comments. Thanks for reviewing.
Comment on attachment 148773 [details]
Patch v2
LGTM
Comment on attachment 148773 [details] Patch v2 Clearing flags on attachment: 148773 Committed r120921: <http://trac.webkit.org/changeset/120921> All reviewed patches have been landed. Closing bug. |