Bug 87925

Summary: [V8] Expando properties on attribute nodes disappear
Product: WebKit Reporter: Dominic Cooney <dominicc>
Component: DOMAssignee: Dominic Cooney <dominicc>
Severity: Normal CC: abarth, dominicc, haraken, japhet, jbadics, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 88045, 88062    
Bug Blocks:    
Description Flags
Repro. Must run Chrome with --js-flags=--expose_gc.
Patch none

Description Dominic Cooney 2012-05-30 22:01:19 PDT
Created attachment 144983 [details]
Repro. Must run Chrome with --js-flags=--expose_gc.

Object grouping for attribute nodes is incorrect. See the attached repro. It should print "magic", "magic" but because the attribute node wrapper is collected prematurely, it prints "magic", "undefined".
Comment 1 Dominic Cooney 2012-05-31 21:46:29 PDT
Created attachment 145208 [details]
Comment 2 Dominic Cooney 2012-05-31 21:47:19 PDT
Comment on attachment 145208 [details]

Filed bug 88045 for JSC. It seems the same bug exists in JSC bindings.
Comment 3 Adam Barth 2012-05-31 22:13:31 PDT
Comment on attachment 145208 [details]

LGTM.  You might want to run this patch by haraken before landing.
Comment 4 Kentaro Hara 2012-05-31 22:26:59 PDT
Comment on attachment 145208 [details]

LGTM from me too
Comment 5 WebKit Review Bot 2012-05-31 23:37:22 PDT
Comment on attachment 145208 [details]

Clearing flags on attachment: 145208

Committed r119196: <http://trac.webkit.org/changeset/119196>
Comment 6 WebKit Review Bot 2012-05-31 23:37:30 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 János Badics 2012-06-01 01:25:32 PDT
A newly added test (fast/dom/gc-attribute-node.html) fails on Qt, GTK and EFL 64 bit since r119196. I will skip this test until the problem is solved.