Bug 87814

Summary: [V8] Implement V8Binding::v8BooleanWithCheck(isolate)
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 84074    
Attachments:
Description Flags
Patch none

Kentaro Hara
Reported 2012-05-29 20:57:18 PDT
The objective is to pass Isolate to v8::True() and v8::False(). Similarly to v8NullWithCheck() (bug 87713), we can implement V8Binding::v8BooleanWithCheck(isolate), which calls v8::True()/v8::False() or v8::True(isolate)/v8::False(isolate) depending on whether the passed isolate is null or not.
Attachments
Patch (6.61 KB, patch)
2012-05-29 21:03 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-05-29 21:03:46 PDT
Created attachment 144688 [details] Patch
WebKit Review Bot
Comment 2 2012-05-30 17:29:52 PDT
Comment on attachment 144688 [details] Patch Clearing flags on attachment: 144688 Committed r119003: <http://trac.webkit.org/changeset/119003>
WebKit Review Bot
Comment 3 2012-05-30 17:29:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.