Bug 87605

Summary: [BlackBerry] WebKit-side implementation of SelectionOverlay
Product: WebKit Reporter: Arvid Nilsson <anilsson>
Component: WebKit BlackBerryAssignee: Arvid Nilsson <anilsson>
Status: RESOLVED FIXED    
Severity: Normal CC: kpiascik, manyoso, mifenton, mlattanzio, rwlbuis, staikos, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 87604    
Bug Blocks: 87606    
Attachments:
Description Flags
Patch
none
Patch none

Arvid Nilsson
Reported 2012-05-27 15:12:55 PDT
Leverage the new WebOverlay API to move SelectionOverlay to the WebKit library, so we always draw selection regardless of which embedder is integrating WebKit. Please note that this has not been internally reviewed yet, so it needs actual review. And also, it has a dependency that needs to be landed first.
Attachments
Patch (16.15 KB, patch)
2012-05-27 16:37 PDT, Arvid Nilsson 		no flags
DetailsFormatted DiffDiff
Patch (16.12 KB, patch)
2012-05-28 14:51 PDT, Arvid Nilsson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Arvid Nilsson
Comment 1 2012-05-27 16:37:45 PDT
Created attachment 144252 [details] Patch
Arvid Nilsson
Comment 2 2012-05-27 16:55:08 PDT
PR #160263
Mike Fenton
Comment 3 2012-05-28 07:31:29 PDT
Comment on attachment 144252 [details] Patch Looks good to me.
Rob Buis
Comment 4 2012-05-28 08:16:48 PDT
Comment on attachment 144252 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144252&action=review Looks good. > Source/WebKit/blackberry/WebKitSupport/SelectionOverlay.cpp:32 > +#include <SkCornerPathEffect.h> Is this used?
Arvid Nilsson
Comment 5 2012-05-28 08:51:22 PDT
(In reply to comment #4) > (From update of attachment 144252 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=144252&action=review > > Looks good. > > > Source/WebKit/blackberry/WebKitSupport/SelectionOverlay.cpp:32 > > +#include <SkCornerPathEffect.h> > > Is this used? Oops, no it's not - I will upload a new patch
Arvid Nilsson
Comment 6 2012-05-28 14:51:17 PDT
Created attachment 144400 [details] Patch
Rob Buis
Comment 7 2012-05-29 08:12:30 PDT
Comment on attachment 144400 [details] Patch Looks good.
WebKit Review Bot
Comment 8 2012-05-29 09:06:30 PDT
Comment on attachment 144400 [details] Patch Clearing flags on attachment: 144400 Committed r118785: <http://trac.webkit.org/changeset/118785>
WebKit Review Bot
Comment 9 2012-05-29 09:06:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.