Summary: | [BlackBerry] Update WebPageCompositor::render() API | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Arvid Nilsson <anilsson> | ||||
Component: | WebKit BlackBerry | Assignee: | Arvid Nilsson <anilsson> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | rwlbuis, tonikitoo, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 87564 | ||||||
Bug Blocks: | 87567 | ||||||
Attachments: |
|
Description
Arvid Nilsson
2012-05-25 22:16:05 PDT
And this one, in between the other two: commit 65c17ae0be75eb6c0db392b649e36528e55364be Author: Arvid Nilsson <anilsson@rim.com> Date: Wed Apr 25 14:27:15 2012 +0200 2012-04-25 Arvid Nilsson <anilsson@rim.com> Another compositing change, another simulator build fix PR #151887 Reviewed by Torch BuildBot. * Api/WebPageCompositor.cpp: (BlackBerry::WebKit::WebPageCompositor::render): This one also belongs in here: commit 5b2bef3baa081daf8757ed785ec3a20a6a7cfe4a Author: Arvid Nilsson <anilsson@rim.com> Date: Tue May 8 23:52:21 2012 +0200 2012-05-08 Arvid Nilsson <anilsson@rim.com> Remove unused variables Reviewed by Jacky Jiang. * Api/BackingStore.cpp: (BlackBerry::WebKit::BackingStorePrivate::compositeContents): Created attachment 144228 [details]
Patch
Comment on attachment 144228 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144228&action=review Looks good. > Source/WebCore/platform/graphics/blackberry/LayerRenderer.cpp:321 > + return; Could combine with above if. > Source/WebCore/platform/graphics/blackberry/LayerRenderer.cpp:325 > + for (size_t i = 0; i < sublayers.size(); i++) { might want to stick to always using ++i or i++, now it is inconsistent. > Source/WebCore/platform/graphics/blackberry/LayerRenderer.cpp:326 > + float opacity = 1; I am not sure this extra var is needed. Comment on attachment 144228 [details] Patch Clearing flags on attachment: 144228 Committed r118696: <http://trac.webkit.org/changeset/118696> All reviewed patches have been landed. Closing bug. |