RESOLVED FIXED 87564
[BlackBerry] Plumb through the return value of makeCurrent to the caller 
https://bugs.webkit.org/show_bug.cgi?id=87564
Summary [BlackBerry] Plumb through the return value of makeCurrent to the caller
Arvid Nilsson
Reported 2012-05-25 22:12:40 PDT
Source/WebKit/blackberry: 2012-04-21 Arvid Nilsson <anilsson@rim.com> Plumb through the return value of makeCurrent to the caller PR #149721 Reviewed by George Staikos. * WebKitSupport/GLES2Context.cpp: (BlackBerry::WebKit::GLES2Context::makeCurrent): Source/WebCore: 2012-04-21 Arvid Nilsson <anilsson@rim.com> Bail if we fail to make the context current PR #149721 Let initializeSharedGLObjects return false if we fail to make the GL context current, so we never enter the "hardware compositing" state. Also bail from drawLayers() if we're not hardware compositing. Reviewed by George Staikos. Tested by forcing the GLES2Context to return false from makeCurrent. * platform/graphics/blackberry/LayerRenderer.cpp: (WebCore::LayerRenderer::~LayerRenderer): (WebCore::LayerRenderer::drawLayers): (WebCore::LayerRenderer::initializeSharedGLObjects):
Attachments
Patch (1.67 KB, patch)
2012-05-27 05:53 PDT, Arvid Nilsson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Arvid Nilsson
Comment 1 2012-05-27 05:53:23 PDT
Created attachment 144227 [details] Patch
Mike Fenton
Comment 2 2012-05-28 08:26:58 PDT
Looks good to me.
Rob Buis
Comment 3 2012-05-28 08:29:10 PDT
Comment on attachment 144227 [details] Patch Looks good.
WebKit Review Bot
Comment 4 2012-05-28 09:24:01 PDT
Comment on attachment 144227 [details] Patch Clearing flags on attachment: 144227 Committed r118689: <http://trac.webkit.org/changeset/118689>
WebKit Review Bot
Comment 5 2012-05-28 09:24:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.