WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
87567
[BlackBerry] Add an Overlay layer
https://bugs.webkit.org/show_bug.cgi?id=87567
Summary
[BlackBerry] Add an Overlay layer
Arvid Nilsson
Reported
2012-05-25 22:20:54 PDT
The overlay layer allows us to have compositing layers even though the web page is not currently using accelerated compositing. These layers can be used to implement tap highlight, inspector overlay and more. Reviewed by Filip Spacek. The WebCore changes support the overlay layer functionality in WebKit by making it possible to add animations from the compositing thread without them being instantly overwritten during the next commit. Also a new custom layer type is added, which allow an overlay layer to draw itself using raw OpenGL calls. An instance of a custom subclass of LayerCompositingThread must be provided when creating the LayerWebKitThread. Then, the custom layer can be used as the content layer of a GraphicsLayer, or by itself.
Attachments
Patch
(24.49 KB, patch)
2012-05-27 06:31 PDT
,
Arvid Nilsson
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Arvid Nilsson
Comment 1
2012-05-27 06:31:34 PDT
Created
attachment 144230
[details]
Patch
Antonio Gomes
Comment 2
2012-05-27 07:08:34 PDT
Comment on
attachment 144230
[details]
Patch simply awesome!!!
Antonio Gomes
Comment 3
2012-05-27 07:09:28 PDT
did not set cq+, since it does not seem to apply. ping me when it is ready to land (its dependencies have landed, for example).
Arvid Nilsson
Comment 4
2012-05-27 11:03:30 PDT
(In reply to
comment #2
)
> (From update of
attachment 144230
[details]
) > simply awesome!!!
It gets a lot better - there's a whole series of upcoming "overlay" patches to create a public BlackBerry::WebKit::WebOverlay API for adding AC layers to the web page =)
WebKit Review Bot
Comment 5
2012-05-28 11:29:45 PDT
Comment on
attachment 144230
[details]
Patch Clearing flags on attachment: 144230 Committed
r118699
: <
http://trac.webkit.org/changeset/118699
>
WebKit Review Bot
Comment 6
2012-05-28 11:29:50 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug