Bug 87196

Summary: [Chromium-Android] Fix chromium_android_unittest
Product: WebKit Reporter: Xianzhu Wang <wangxianzhu>
Component: Tools / TestsAssignee: Xianzhu Wang <wangxianzhu>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, ojan, peter, rakuco, webkit.review.bot, zhenghao
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 86862    
Attachments:
Description Flags
patch
none
patch v2
tony: review+, tony: commit-queue-
patch v3 none

Xianzhu Wang
Reported 2012-05-22 19:08:41 PDT
chromium_android_unittest is broken by http://trac.webkit.org/changeset/118089. Will disable the test first and then fix it. Sorry for the breakage.
Attachments
patch (9.04 KB, patch)
2012-05-23 12:34 PDT, Xianzhu Wang 		no flags
DetailsFormatted DiffDiff
patch v2 (9.04 KB, patch)
2012-05-23 12:38 PDT, Xianzhu Wang 		tony: review+
tony: commit-queue-
DetailsFormatted DiffDiff
patch v3 (9.43 KB, patch)
2012-05-23 13:28 PDT, Xianzhu Wang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Xianzhu Wang
Comment 1 2012-05-22 19:21:14 PDT
Temporarily disable chromium_android_unittest: http://trac.webkit.org/changeset/118100
Xianzhu Wang
Comment 2 2012-05-23 12:34:24 PDT
Created attachment 143618 [details] patch
Xianzhu Wang
Comment 3 2012-05-23 12:38:46 PDT
Created attachment 143622 [details] patch v2
Tony Chang
Comment 4 2012-05-23 13:10:15 PDT
Comment on attachment 143622 [details] patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=143622&action=review > Tools/ChangeLog:16 > + * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py: > + (ChromiumAndroidPortTest): > + (ChromiumAndroidPortTest.mock_run_command_fn): > + (ChromiumAndroidPortTest.test_get_last_stacktrace): > + (ChromiumAndroidPortTest.test_get_crash_log): > + (ChromiumAndroidDriverTest): > + (ChromiumAndroidDriverTest.setUp): > + (ChromiumAndroidDriverTest.test_cmd_line): > + (ChromiumAndroidDriverTest.test_write_command_and_read_line): Please describe your changes here.
Xianzhu Wang
Comment 5 2012-05-23 13:28:31 PDT
Created attachment 143634 [details] patch v3
Xianzhu Wang
Comment 6 2012-05-23 13:28:52 PDT
Comment on attachment 143622 [details] patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=143622&action=review >> Tools/ChangeLog:16 >> + (ChromiumAndroidDriverTest.test_write_command_and_read_line): > > Please describe your changes here. Done.
WebKit Review Bot
Comment 7 2012-05-23 14:13:08 PDT
Comment on attachment 143634 [details] patch v3 Clearing flags on attachment: 143634 Committed r118244: <http://trac.webkit.org/changeset/118244>
WebKit Review Bot
Comment 8 2012-05-23 14:13:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.