Summary: | [Gtk] Move feature defines processing into a GNUmakefile that's simple to autogenerate | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||||||
Component: | WebKitGTK | Assignee: | Zan Dobersek <zan> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | eric, mrobinson, xan.lopez | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 87995, 90693, 90696 | ||||||||||
Bug Blocks: | 85456 | ||||||||||
Attachments: |
|
Description
Zan Dobersek
2012-05-22 06:22:43 PDT
One important usecase to consider is that we often enable things for build-webkit and disable them for normal configure runs. This allows us to have the bots test something and not ship it. (In reply to comment #1) > One important usecase to consider is that we often enable things for build-webkit and disable them for normal configure runs. This allows us to have the bots test something and not ship it. I can't imagine a solution to this from the top of my head other than manually going through the list of the feature defines and switching their status if necessary after the release branch is formed. (In reply to comment #2) > (In reply to comment #1) > > One important usecase to consider is that we often enable things for build-webkit and disable them for normal configure runs. This allows us to have the bots test something and not ship it. > > I can't imagine a solution to this from the top of my head other than manually going through the list of the feature defines and switching their status if necessary after the release branch is formed. Unfortunately, it's not just the release branch, but also in unstable releases as well. Created attachment 145118 [details]
Patch
Created attachment 151109 [details]
Patch
Created attachment 158546 [details]
Patch
Comment on attachment 158546 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158546&action=review Okay, but definitely watch the bots on this one. It may also be a good idea to double-check "make distcheck" > Source/WebCore/GNUmakefile.am:650 > ACCELERATED_COMPOSITING=1 This introduces an unused -DACCELERATED_COMPOSITING variable. I guess that's not a terrible side-effect. > Source/WebCore/GNUmakefile.am:793 > +# Add the feature defines to webcore_cppflags in macro form Nit: Missing a period on this comment. > GNUmakefile.am:64 > +FEATURE_DEFINES_DEFAULTS := > +FEATURE_DEFINES_OVERRIDES := > +FEATURE_DEFINES := I think it'd make sense to use small_case here to match other variables. Comment on attachment 158546 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158546&action=review >> Source/WebCore/GNUmakefile.am:650 >> ACCELERATED_COMPOSITING=1 > > This introduces an unused -DACCELERATED_COMPOSITING variable. I guess that's not a terrible side-effect. I'll remove this define as it's not used at all. Committed as http://trac.webkit.org/changeset/126450. *** Bug 85753 has been marked as a duplicate of this bug. *** |