Bug 90696 - [Gtk] Include all files guarded by ENABLE_* guards in Source/WebCore/GNUmakefile.list.am into the build
Summary: [Gtk] Include all files guarded by ENABLE_* guards in Source/WebCore/GNUmakef...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks: 87127
  Show dependency tree / graph
 
Reported: 2012-07-06 10:23 PDT by Zan Dobersek
Modified: 2012-08-14 23:59 PDT (History)
4 users (show)

See Also:

Attachments
Patch (482.59 KB, patch)
2012-07-06 10:41 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch (482.63 KB, patch)
2012-07-09 12:43 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch (486.87 KB, patch)
2012-08-14 00:23 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2012-07-06 10:23:58 PDT 
Include all the WebCore source files that are guarded by ENABLE_* guards into the build, relying on proper in-source ENABLE_* guarding and the preprocessor to do the work of keeping unneeded/disabled code out of compilation.
Comment 1 Zan Dobersek 2012-07-06 10:30:38 PDT 
Fixing the title, the story's about GNUmakefile.list.am.
Comment 2 Zan Dobersek 2012-07-06 10:41:33 PDT 
Created attachment 151100 [details]
Patch
Comment 3 Philippe Normand 2012-07-06 17:14:33 PDT 
We know the preprocessor is supposed to be fast but can you provide clean build comparison times?
Comment 4 Zan Dobersek 2012-07-07 06:47:39 PDT 
(In reply to comment #3)
> We know the preprocessor is supposed to be fast but can you provide clean build comparison times?

ToT:
build-webkit --gtk --no-webkit2: 38m07s
build-webkit --gtk --no-webkit2 --no-svg: 30m30s

With patch:
build-webkit --gtk --no-webkit2: 38m19s
build-webkit --gtk --no-webkit2 --no-svg: 30m57s

A couple of seconds longer, but no real drawbacks time-wise.
Comment 5 Philippe Normand 2012-07-09 11:29:08 PDT 
Comment on attachment 151100 [details]
Patch

Patch looks good! But can you please rebase it and upload again for EWS check?
Comment 6 Zan Dobersek 2012-07-09 12:43:46 PDT 
Created attachment 151302 [details]
Patch

A rebased patch.
Comment 7 Zan Dobersek 2012-08-14 00:23:19 PDT 
Created attachment 158242 [details]
Patch

Updated patch
Comment 8 Philippe Normand 2012-08-14 02:01:06 PDT 
Comment on attachment 158242 [details]
Patch

EWS didn't complain, let's try! Thanks Zan!
Comment 9 Zan Dobersek 2012-08-14 02:10:05 PDT 
(In reply to comment #8)
> (From update of attachment 158242 [details])
> EWS didn't complain, let's try! Thanks Zan!

Thanks for the review, I'll land this carefully later today. Hopefully the patch will still apply :>
Comment 10 Zan Dobersek 2012-08-14 23:59:18 PDT 
Committed as http://trac.webkit.org/changeset/125583 without problems.