Bug 86927

Summary: [chromium] remove --test-shell support from DRT
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: Tools / TestsAssignee: Xianzhu Wang <wangxianzhu>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, falken, peter, tkent, tony, wangxianzhu, webkit.review.bot, zhenghao
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 88542    
Bug Blocks: 91532    
Attachments:
Description Flags
Patch none

Dirk Pranke
Reported 2012-05-18 17:22:40 PDT
We no longer need it.
Attachments
Patch (16.30 KB, patch)
2012-07-17 10:45 PDT, Xianzhu Wang 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Xianzhu Wang
Comment 1 2012-07-13 11:03:23 PDT
I'll do this after finish bug 85542.
Xianzhu Wang
Comment 2 2012-07-13 11:04:12 PDT
Sorry, should be bug 88542.
Xianzhu Wang
Comment 3 2012-07-17 10:45:29 PDT
Created attachment 152782 [details] Patch
WebKit Review Bot
Comment 4 2012-07-17 12:02:11 PDT
Comment on attachment 152782 [details] Patch Clearing flags on attachment: 152782 Committed r122866: <http://trac.webkit.org/changeset/122866>
WebKit Review Bot
Comment 5 2012-07-17 12:02:16 PDT
All reviewed patches have been landed. Closing bug.
Matt Falkenhagen
Comment 6 2012-07-17 20:42:41 PDT
The extension API documentation build script in Chrome, chrome/common/extensions/docs/build/build.py, uses --test-shell. It seems with this change, the script fails. Is there some other option it should be using? https://code.google.com/p/chromium/issues/detail?id=137798
Dirk Pranke
Comment 7 2012-07-17 22:31:29 PDT
(In reply to comment #6) > The extension API documentation build script in Chrome, chrome/common/extensions/docs/build/build.py, uses --test-shell. It seems with this change, the script fails. Is there some other option it should be using? > > https://code.google.com/p/chromium/issues/detail?id=137798 Commented in the chromium bug. Let's discuss this there first.
Note You need to log in before you can comment on or make changes to this bug.