Bug 86927

Summary:

[chromium] remove --test-shell support from DRT

Product:

WebKit

Reporter:

Dirk Pranke <dpranke>

Component:

Tools / Tests

Assignee:

Xianzhu Wang <wangxianzhu>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dpranke, falken, peter, tkent, tony, wangxianzhu, webkit.review.bot, zhenghao

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

88542

Bug Blocks:

91532

Attachments:

Description	Flags
Patch	none

Description Dirk Pranke 2012-05-18 17:22:40 PDT

We no longer need it.

Comment 1 Xianzhu Wang 2012-07-13 11:03:23 PDT

I'll do this after finish bug 85542.

Comment 2 Xianzhu Wang 2012-07-13 11:04:12 PDT

Sorry, should be bug 88542.

Comment 3 Xianzhu Wang 2012-07-17 10:45:29 PDT

Created attachment 152782 [details]
Patch

Comment 4 WebKit Review Bot 2012-07-17 12:02:11 PDT

Comment on attachment 152782 [details]
Patch

Clearing flags on attachment: 152782

Committed r122866: <http://trac.webkit.org/changeset/122866>

Comment 5 WebKit Review Bot 2012-07-17 12:02:16 PDT

All reviewed patches have been landed.  Closing bug.

Comment 6 Matt Falkenhagen 2012-07-17 20:42:41 PDT

The extension API documentation build script in Chrome, chrome/common/extensions/docs/build/build.py, uses --test-shell. It seems with this change, the script fails. Is there some other option it should be using?

https://code.google.com/p/chromium/issues/detail?id=137798

Comment 7 Dirk Pranke 2012-07-17 22:31:29 PDT

(In reply to comment #6)
> The extension API documentation build script in Chrome, chrome/common/extensions/docs/build/build.py, uses --test-shell. It seems with this change, the script fails. Is there some other option it should be using?
> 
> https://code.google.com/p/chromium/issues/detail?id=137798

Commented in the chromium bug. Let's discuss this there first.