Bug 85542 – --coverage should not not use the "feature" options system in build-webkit, similarly remove special-casing for WTF_URL

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Eric Seidel (no email)]

--coverage should not not use the "feature" options system in build-webkit, similarly remove special-casing for WTF_URL

[Eric Seidel (no email)]

Created attachment 140091 [details]
Patch

[Eric Seidel (no email)]

Once this lands, I"ll move that big array of into its own file and then update my generate-feature-files command to autogenerate it. :)  (See bug 85456.)

[Daniel Bates]

Comment on attachment 140091 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140091&action=review

Looks good to me.

> Tools/ChangeLog:15
> +        It should probably come back to life as an ENABLE_, or build-webkit or the XCode projects

Nit: XCode => Xcode

[Eric Seidel (no email)]

Sorry, I always get that wrong.  There was some discussion of making the style-checker check for such. :)  Will fix.

[Eric Seidel (no email)]

Created attachment 140093 [details]
Patch for landing

[Eric Seidel (no email)]

Created attachment 140106 [details]
Patch for landing

[Benjamin Poulain]

Comment on attachment 140106 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=140106&action=review

> Tools/ChangeLog:14
> +        I'm told that WTF_URL is not actively being worked on, so just removing it for now.

Actually I did not update for a while for personal reasons.

I should resume work on WTFURL this weekend.

[WebKit Review Bot]

Comment on attachment 140106 [details]
Patch for landing

Clearing flags on attachment: 140106

Committed r116036: <http://trac.webkit.org/changeset/116036>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Eric Seidel (no email)]

We should probably just make WTF_URL an ENABLE.  I'm very happy to see that support continue to be worked on.  The support in build-webkit or WTF_URL was a one-off.

[Benjamin Poulain]

(In reply to comment #10)
> We should probably just make WTF_URL an ENABLE.  I'm very happy to see that support continue to be worked on.  The support in build-webkit or WTF_URL was a one-off.

It will be a strange ENABLE but that is fine by me if that is the solution. I'll make a patch.

[Eric Seidel (no email)]

Yeah, it's a bit odd.  That's probably the easiest way to deal with XCode however, since ENABLE_ seems special cased there.  Mark Rowe might know more about the details of how/why ENABLE_ handling is magical.

[Eric Seidel (no email)]

I should also note that I'm not opposed to adding back in the CFLAGS special casing for WTF_URL if that's needed.  Just cleaning up these feature options code while I'm in there.