| Summary: | Frame flattening should not expand tiny frames | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||
| Component: | Frames | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | eric, webkit.review.bot, zalan | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Antti Koivisto
2012-05-17 08:13:30 PDT
Created attachment 142477 [details]
patch
Comment on attachment 142477 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=142477&action=review > Source/WebCore/ChangeLog:10 > + If a frame has so small fixed size that it is not usefully scrollable on desktop it is probably > + not meant to be scrolled. Displaying any otherwise invisible content by expanding the frame > + may end up looking like a rendering error. Shouldnt we then disable actual scrolling of it? (In reply to comment #3) > Shouldnt we then disable actual scrolling of it? We probably don't want to alter the non-flattened behavior if that's what you mean. Web developers are allowed to do stupid things. We just want to prevent flattening displaying garbage that is not easily visible otherwise. Comment on attachment 142477 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=142477&action=review > LayoutTests/fast/frames/flattening/iframe-tiny.html:40 > +<iframe id="testFrame0" width="0px" height="0px" style="border-width:0px" scrolling=auto src="data:text/html, There are nicer ways besides copy/paste :) Also srcdoc= is the new hotness. |