Bug 86449

Summary: Rename Node::shadowTreeRootNode() to Node::shadowRoot()
Product: WebKit Reporter: Shinya Kawanaka <shinyak>
Component: DOMAssignee: Shinya Kawanaka <shinyak>
Status: RESOLVED FIXED    
Severity: Normal CC: dominicc, hayato, morrita, tasak, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 86428    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Shinya Kawanaka
Reported 2012-05-15 00:03:12 PDT
In the discussion for Bug 86428, we concluded that we should rename Node::shadowTreeRootNode() to shadowRoot().
Attachments
Patch (15.42 KB, patch)
2012-05-15 01:37 PDT, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch for landing (15.01 KB, patch)
2012-05-15 19:29 PDT, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch for landing (15.33 KB, patch)
2012-05-15 19:43 PDT, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Shinya Kawanaka
Comment 1 2012-05-15 01:37:04 PDT
Created attachment 141891 [details] Patch
WebKit Review Bot
Comment 2 2012-05-15 18:43:14 PDT
Comment on attachment 141891 [details] Patch Rejecting attachment 141891 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: g rejects to file Source/WebCore/html/shadow/HTMLContentElement.cpp.rej patching file Source/WebCore/html/shadow/InsertionPoint.cpp patching file Source/WebCore/page/EventHandler.cpp patching file Source/WebCore/svg/SVGElement.cpp patching file Source/WebKit/chromium/src/WebFrameImpl.cpp Hunk #1 succeeded at 1784 (offset 18 lines). Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Darin Adler']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12709261
Shinya Kawanaka
Comment 3 2012-05-15 19:29:15 PDT
Created attachment 142130 [details] Patch for landing
Shinya Kawanaka
Comment 4 2012-05-15 19:43:55 PDT
Created attachment 142132 [details] Patch for landing
Shinya Kawanaka
Comment 5 2012-05-15 20:06:33 PDT
Committed r117210: <http://trac.webkit.org/changeset/117210>
Note You need to log in before you can comment on or make changes to this bug.