Bug 86428

Summary: Node::shadowTreeRootNode() should return ShadowRoot instead of Node.
Product: WebKit Reporter: Shinya Kawanaka <shinyak>
Component: DOMAssignee: Shinya Kawanaka <shinyak>
Status: RESOLVED FIXED    
Severity: Normal CC: morrita
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 86449    
Attachments:
Description Flags
Patch morrita: review+

Description Shinya Kawanaka 2012-05-14 19:08:05 PDT 
It definitely returns only ShadowRoot. Then the return type should be ShadowRoot.
Comment 1 Shinya Kawanaka 2012-05-14 19:44:35 PDT 
Created attachment 141844 [details]
Patch
Comment 2 Shinya Kawanaka 2012-05-14 20:57:25 PDT 
maybe OK to build. I'll reuse the same patch for review.
Comment 3 Hajime Morrita 2012-05-14 23:02:14 PDT 
Comment on attachment 141844 [details]
Patch

How about to just call it shadowRoot()?
Comment 4 Shinya Kawanaka 2012-05-14 23:42:28 PDT 
(In reply to comment #3)
> (From update of attachment 141844 [details])
> How about to just call it shadowRoot()?

OK. I'll update the patch soon.
Comment 5 Shinya Kawanaka 2012-05-14 23:58:34 PDT 
(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 141844 [details] [details])
> > How about to just call it shadowRoot()?
> 
> OK. I'll update the patch soon.

Ah, I found that it is easy to fix the name after Bug 86341 is landed.
Let rename later...
Comment 6 Hajime Morrita 2012-05-14 23:59:43 PDT 
Comment on attachment 141844 [details]
Patch

rs=me
Comment 7 Shinya Kawanaka 2012-05-15 00:11:20 PDT 
Committed r117036: <http://trac.webkit.org/changeset/117036>