| Summary: | Use emptyString instead of String("") | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Rob Buis <rwlbuis> | ||||
| Component: | WebCore Misc. | Assignee: | Rob Buis <rwlbuis> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | eric, tkent, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 97320 | ||||||
| Attachments: |
|
||||||
Created attachment 141588 [details]
Patch
Comment on attachment 141588 [details]
Patch
We should also use emptyString() instead of just "" with an implicit conversion to String. Should find a some good way to locate those.
Are there things I can do to make webkit-patch land work better for you? Or perhaps you'd like to use webkit-patch mark-bug-fixed after landing yourself? You're welcome of course to use neither, but I'm surprised to see people adding their own "landed" messages by hand these days. (In reply to comment #4) > Are there things I can do to make webkit-patch land work better for you? Not really. It worked fine whenever I tried it. > Or perhaps you'd like to use webkit-patch mark-bug-fixed after landing yourself? > > You're welcome of course to use neither, but I'm surprised to see people adding their own "landed" messages by hand these days. I often like to keep the bug open a day or so in case anybody complains/there are regressions. I could try looking into webkit-patch mark-bug-fixed though. Workflow sometimes is hard to change, but I'll give that one a shot, thanks! Cheers, Rob. |
Use emptyString() instead of String("") because it is better style and faster.