Bug 86305

Summary: Use emptyString instead of String("")
Product: WebKit Reporter: Rob Buis <rwlbuis>
Component: WebCore Misc.Assignee: Rob Buis <rwlbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 97320    
Attachments:
Description Flags
Patch darin: review+

Rob Buis
Reported 2012-05-12 16:42:08 PDT
Use emptyString() instead of String("") because it is better style and faster.
Attachments
Patch (8.54 KB, patch)
2012-05-12 16:48 PDT, Rob Buis 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2012-05-12 16:48:08 PDT
Created attachment 141588 [details] Patch
Darin Adler
Comment 2 2012-05-13 15:52:33 PDT
Comment on attachment 141588 [details] Patch We should also use emptyString() instead of just "" with an implicit conversion to String. Should find a some good way to locate those.
Rob Buis
Comment 3 2012-05-14 16:23:50 PDT
Landed in r116908.
Eric Seidel (no email)
Comment 4 2012-05-14 16:32:10 PDT
Are there things I can do to make webkit-patch land work better for you? Or perhaps you'd like to use webkit-patch mark-bug-fixed after landing yourself? You're welcome of course to use neither, but I'm surprised to see people adding their own "landed" messages by hand these days.
Rob Buis
Comment 5 2012-05-14 16:38:57 PDT
(In reply to comment #4) > Are there things I can do to make webkit-patch land work better for you? Not really. It worked fine whenever I tried it. > Or perhaps you'd like to use webkit-patch mark-bug-fixed after landing yourself? > > You're welcome of course to use neither, but I'm surprised to see people adding their own "landed" messages by hand these days. I often like to keep the bug open a day or so in case anybody complains/there are regressions. I could try looking into webkit-patch mark-bug-fixed though. Workflow sometimes is hard to change, but I'll give that one a shot, thanks! Cheers, Rob.
Note You need to log in before you can comment on or make changes to this bug.