Bug 86121

Summary: [Chromium] Remove WEBKIT_USING_SKIA ifdefs that are always true
Product: WebKit Reporter: Mark Pilgrim (Google) <pilgrim>
Component: New BugsAssignee: Mark Pilgrim (Google) <pilgrim>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, jamesr, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Mark Pilgrim (Google)
Reported 2012-05-10 11:32:58 PDT
As discussed in https://bugs.webkit.org/show_bug.cgi?id=86018#c9
Attachments
Patch (12.93 KB, patch)
2012-05-10 12:18 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2012-05-10 11:36:31 PDT
Equivalent chromium patch is here: https://chromiumcodereview.appspot.com/10391041/ once that lands it should be possible to remove the WEBKIT_USING_SKIA definition from WebCommon.h
Mark Pilgrim (Google)
Comment 2 2012-05-10 12:18:59 PDT
Created attachment 141222 [details] Patch
Mark Pilgrim (Google)
Comment 3 2012-05-10 12:19:37 PDT
This patch does not touch WebCommon.h.
WebKit Review Bot
Comment 4 2012-05-10 12:20:19 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Adam Barth
Comment 5 2012-05-10 13:02:24 PDT
Thanks!
WebKit Review Bot
Comment 6 2012-05-10 14:43:20 PDT
Comment on attachment 141222 [details] Patch Clearing flags on attachment: 141222 Committed r116689: <http://trac.webkit.org/changeset/116689>
WebKit Review Bot
Comment 7 2012-05-10 14:43:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.