Bug 86121

Summary: [Chromium] Remove WEBKIT_USING_SKIA ifdefs that are always true
Product: WebKit Reporter: Mark Pilgrim (Google) <pilgrim>
Component: New BugsAssignee: Mark Pilgrim (Google) <pilgrim>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, jamesr, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Mark Pilgrim (Google) 2012-05-10 11:32:58 PDT 
As discussed in https://bugs.webkit.org/show_bug.cgi?id=86018#c9
Comment 1 James Robinson 2012-05-10 11:36:31 PDT 
Equivalent chromium patch is here: https://chromiumcodereview.appspot.com/10391041/

once that lands it should be possible to remove the WEBKIT_USING_SKIA definition from WebCommon.h
Comment 2 Mark Pilgrim (Google) 2012-05-10 12:18:59 PDT 
Created attachment 141222 [details]
Patch
Comment 3 Mark Pilgrim (Google) 2012-05-10 12:19:37 PDT 
This patch does not touch WebCommon.h.
Comment 4 WebKit Review Bot 2012-05-10 12:20:19 PDT 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 5 Adam Barth 2012-05-10 13:02:24 PDT 
Thanks!
Comment 6 WebKit Review Bot 2012-05-10 14:43:20 PDT 
Comment on attachment 141222 [details]
Patch

Clearing flags on attachment: 141222

Committed r116689: <http://trac.webkit.org/changeset/116689>
Comment 7 WebKit Review Bot 2012-05-10 14:43:25 PDT 
All reviewed patches have been landed.  Closing bug.