Summary: | MediaStream API: Adding a test for constructed from JS MediaStreams | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tommy Widenflycht <tommyw> | ||||||
Component: | Tools / Tests | Assignee: | Tommy Widenflycht <tommyw> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | eric.carlson, feature-media-reviews, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 56587 | ||||||||
Attachments: |
|
Description
Tommy Widenflycht
2012-05-08 07:04:47 PDT
Created attachment 140714 [details]
Patch
Comment on attachment 140714 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140714&action=review > LayoutTests/fast/mediastream/MediaStreamConstructor.html:14 > +function shouldNotThrow(expression) > +{ * This should be in js-test-pre.js. * The position of { is inconsistent with other functions. > LayoutTests/fast/mediastream/MediaStreamConstructor.html:21 > + try { > + eval(expression); > + testPassed(expression + " did not throw exception."); > + } catch(e) { > + testFailed(expression + " should not throw exception. Threw exception " + e); > + } > +} We usually use four-space indentation in JavaScript code. We usually put ' ' after 'catch'. Created attachment 140894 [details]
Patch
Comment on attachment 140714 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140714&action=review >> LayoutTests/fast/mediastream/MediaStreamConstructor.html:14 >> +{ > > * This should be in js-test-pre.js. > > * The position of { is inconsistent with other functions. Fixed. >> LayoutTests/fast/mediastream/MediaStreamConstructor.html:21 >> +} > > We usually use four-space indentation in JavaScript code. > We usually put ' ' after 'catch'. Fixed. Comment on attachment 140894 [details]
Patch
Looks ok
Comment on attachment 140894 [details] Patch Clearing flags on attachment: 140894 Committed r116511: <http://trac.webkit.org/changeset/116511> All reviewed patches have been landed. Closing bug. |