Bug 85822

Summary: Add ENABLE_IFRAME_SEAMLESS so Apple can turn off SEAMLESS if needed
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aestes, cdumez, dglazkov, gustavo, philn, vestbo, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Eric Seidel (no email)
Reported 2012-05-07 13:49:56 PDT
Add ENABLE_IFRAME_SEAMLESS so Apple can turn off SEAMLESS if needed
Attachments
Patch (7.32 KB, patch)
2012-05-07 13:50 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.30 KB, patch)
2012-05-07 14:01 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch for landing (8.35 KB, patch)
2012-05-07 14:05 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2012-05-07 13:50:45 PDT
Created attachment 140581 [details] Patch
Early Warning System Bot
Comment 2 2012-05-07 13:55:23 PDT
Comment on attachment 140581 [details] Patch Attachment 140581 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12656101
Gyuyoung Kim
Comment 3 2012-05-07 13:57:46 PDT
Comment on attachment 140581 [details] Patch Attachment 140581 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/12652130
Early Warning System Bot
Comment 4 2012-05-07 13:59:20 PDT
Comment on attachment 140581 [details] Patch Attachment 140581 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12656104
WebKit Review Bot
Comment 5 2012-05-07 14:00:51 PDT
Comment on attachment 140581 [details] Patch Attachment 140581 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12644257
Eric Seidel (no email)
Comment 6 2012-05-07 14:01:48 PDT
Created attachment 140583 [details] Patch for landing
Eric Seidel (no email)
Comment 7 2012-05-07 14:03:58 PDT
Yes, this means seamless is off for everyone else after this change, which is less than ideal. I'm working on fixing bug 85456 so we don't have to care about this sort of crap in the future.
Eric Seidel (no email)
Comment 8 2012-05-07 14:05:54 PDT
Created attachment 140585 [details] Patch for landing
WebKit Review Bot
Comment 9 2012-05-07 15:02:03 PDT
Comment on attachment 140585 [details] Patch for landing Clearing flags on attachment: 140585 Committed r116356: <http://trac.webkit.org/changeset/116356>
WebKit Review Bot
Comment 10 2012-05-07 15:02:11 PDT
All reviewed patches have been landed. Closing bug.
Andy Estes
Comment 11 2012-05-07 15:50:31 PDT
I'm not sure if you meant to enable or disable ENABLE_IFRAME_SEAMLESS by default. If you meant to enable it by default, then $(ENABLE_IFRAME_SEAMLESS) should be part of FEATURE_DEFINES. If you meant to disable it by default, then it should still be part of FEATURE_DEFINES, but the macro itself should be defined to be the empty string.
Eric Seidel (no email)
Comment 12 2012-05-07 16:16:35 PDT
Sigh. Yes. This is all so remarkably stupid. :) Yet more reason why I need to fix bug 85456. I'll fix the FEATURE_DEFINE setting in a later patch. :) Thanks!
Andy Estes
Comment 13 2012-05-07 16:21:50 PDT
Added to FEATURE_DEFINES in <http://trac.webkit.org/changeset/116367>.
Eric Seidel (no email)
Comment 14 2012-05-07 16:24:41 PDT
Thanks!
Chris Dumez
Comment 15 2012-05-07 22:59:29 PDT
You forgot to enable it in EFL port and now our seamless tests are no longer passing. I will address this in Bug 85861.
Eric Seidel (no email)
Comment 16 2012-05-07 23:01:33 PDT
Thanks. Yup, this is the point of bug 85456, so folks don't have to worry about 8 build systems. :)
Note You need to log in before you can comment on or make changes to this bug.