Summary: | [chromium] REGRESSION(r107389) Visible line artifacts on some JPEG images | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | noel gordon <noel.gordon> | ||||||||||||||
Component: | New Bugs | Assignee: | noel gordon <noel.gordon> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | abarth, dpranke, eric, pkasting, tkent, webkit.review.bot | ||||||||||||||
Priority: | P2 | ||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
URL: | http://www.polepositiongroup.com/img/banners/bg_006.jpg | ||||||||||||||||
Bug Depends on: | |||||||||||||||||
Bug Blocks: | 78323 | ||||||||||||||||
Attachments: |
|
Description
noel gordon
2012-05-06 22:14:50 PDT
Created attachment 140474 [details]
firefox-12.0-jpeg-artifacts.png
Compared Firefox 12.0 Mac rendering, I see the same vertical & horizontal artifacts (picture above). I _don't_ see the artifacts using Firefox 9.0 Mac, so the issue seems to be a regression in libjpeg-turbo that manifests in both Firefox 12, and Chrome 20 http://crbug.com/122951 Created attachment 140477 [details]
firefox-9.0-jpeg.png
No artifacts show up on Firefox 9.0 Mac.
Filed a mozilla bug: https://bugzilla.mozilla.org/show_bug.cgi?id=753235 Looked at Firefox 12.0 again today and I don't see artifacts. Firefox 9.0, 12.0 render fine. Next punt IFAST vs ISLOW DCT decodes. No artifacts with ISLOW, so backing that out, patch coming ... Created attachment 141100 [details]
Patch
Comment on attachment 141100 [details]
Patch
rubber-stamped.
Thank you, and a question: do rebaselines seem slow from your location? (In reply to comment #9) > Thank you, and a question: do rebaselines seem slow from your location? Both of "webkit-patch rebaseline-expectatinos" and garden-o-matic are very slow in Tokyo. Same from Sydney. Over the last three weeks (it seems to me) these tools became noticeably slower. You might try running with -v, to see what those tools are doing. I'm not pariticularly famiiliar with either. Good idea. (In reply to comment #8) > (From update of attachment 141100 [details]) > rubber-stamped. Need to add = IMAGE expectations for some additional tests fast/repaint/block-layout-inline-children-replaced.html tables/mozilla_expected_failures/bugs/bug85016.html Created attachment 141107 [details]
Patch
(In reply to comment #4) > Filed a mozilla bug: https://bugzilla.mozilla.org/show_bug.cgi?id=753235 Closed. Created attachment 141120 [details]
Patch for landing
Comment on attachment 141120 [details] Patch for landing Clearing flags on attachment: 141120 Committed r116636: <http://trac.webkit.org/changeset/116636> All reviewed patches have been landed. Closing bug. (In reply to comment #12) > You might try running with -v, to see what those tools are doing. I'm not pariticularly famiiliar with either. Filed bug 86171 with a -v trace of a rebaseline of one test: total time was 21m 14sec :/ |