Summary: | [EFL] Page caching permission from EFL's FrameLoaderClient | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mikhail Pozdnyakov <mikhail.pozdnyakov> | ||||
Component: | WebKit EFL | Assignee: | Mikhail Pozdnyakov <mikhail.pozdnyakov> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | gyuyoung.kim, lucas.de.marchi, rakuco, tmpsantos, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Mikhail Pozdnyakov
2012-05-04 07:19:42 PDT
Created attachment 140385 [details]
fix
Comment on attachment 140385 [details]
fix
Do you know what commit should have flipped this flag?
(In reply to comment #2) > (From update of attachment 140385 [details]) > Do you know what commit should have flipped this flag? e9ecc747 +2010-04-15 Leandro Pereira <leandro@profusion.mobi> + + Reviewed by Kenneth Rohde Christiansen. + + Add EFL port files to efl/WebCoreSupport. + http://webkit.org/b/35915 + + * efl/WebCoreSupport/FrameLoaderClientEfl.cpp: Added. + * efl/WebCoreSupport/FrameLoaderClientEfl.h: Added. Weird, I remember some page cache-related bugs being sent afterwards, so I thought the missing bits were implemented later. Looks fine, I guess. Comment on attachment 140385 [details]
fix
We also added a setting to our WebKitGTK+ API, do you (plan to )have something of the sort for EFL?
Comment on attachment 140385 [details] fix Clearing flags on attachment: 140385 Committed r116341: <http://trac.webkit.org/changeset/116341> All reviewed patches have been landed. Closing bug. (In reply to comment #5) > (From update of attachment 140385 [details]) > We also added a setting to our WebKitGTK+ API, do you (plan to )have something of the sort for EFL? In EFL we have it in ewk_view: EAPI Eina_Bool ewk_view_setting_page_cache_get(const Evas_Object *o); EAPI Eina_Bool ewk_view_setting_page_cache_set(Evas_Object *o, Eina_Bool enable); I might be wrong, but this patch is causing this test here to crash: fast/frames/frame-crash-with-page-cache.html (In reply to comment #9) > I might be wrong, but this patch is causing this test here to crash: > fast/frames/frame-crash-with-page-cache.html Yes, it is. I rolled out the patch locally and it doesn't crash. I'm gonna open a bug for that. |