Bug 85620

Summary: [EFL] Page caching permission from EFL's FrameLoaderClient
Product: WebKit Reporter: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Component: WebKit EFLAssignee: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, rakuco, tmpsantos, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
fix none

Description Mikhail Pozdnyakov 2012-05-04 07:19:42 PDT
EFL's FrameLoaderClient should allow page caching in order to fix 
fast/events/pagehide-xhr-open.html 
fast/loader/window-properties-restored-from-page-cache.html
and unskip
fast/events/pageshow-pagehide-on-back-cached.html
(and maybe others)
Comment 1 Mikhail Pozdnyakov 2012-05-05 01:39:51 PDT
Created attachment 140385 [details]
fix
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-05-05 09:03:37 PDT
Comment on attachment 140385 [details]
fix

Do you know what commit should have flipped this flag?
Comment 3 Mikhail Pozdnyakov 2012-05-06 07:49:22 PDT
(In reply to comment #2)
> (From update of attachment 140385 [details])
> Do you know what commit should have flipped this flag?

e9ecc747

+2010-04-15  Leandro Pereira  <leandro@profusion.mobi>
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Add EFL port files to efl/WebCoreSupport.
+        http://webkit.org/b/35915
+
+        * efl/WebCoreSupport/FrameLoaderClientEfl.cpp: Added.
+        * efl/WebCoreSupport/FrameLoaderClientEfl.h: Added.
Comment 4 Raphael Kubo da Costa (:rakuco) 2012-05-06 11:53:03 PDT
Weird, I remember some page cache-related bugs being sent afterwards, so I thought the missing bits were implemented later. Looks fine, I guess.
Comment 5 Gustavo Noronha (kov) 2012-05-07 12:01:58 PDT
Comment on attachment 140385 [details]
fix

We also added a setting to our WebKitGTK+ API, do you (plan to )have something of the sort for EFL?
Comment 6 WebKit Review Bot 2012-05-07 13:10:04 PDT
Comment on attachment 140385 [details]
fix

Clearing flags on attachment: 140385

Committed r116341: <http://trac.webkit.org/changeset/116341>
Comment 7 WebKit Review Bot 2012-05-07 13:10:09 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Mikhail Pozdnyakov 2012-05-08 02:27:51 PDT
(In reply to comment #5)
> (From update of attachment 140385 [details])
> We also added a setting to our WebKitGTK+ API, do you (plan to )have something of the sort for EFL?

In EFL we have it in ewk_view:

EAPI Eina_Bool    ewk_view_setting_page_cache_get(const Evas_Object *o);
EAPI Eina_Bool    ewk_view_setting_page_cache_set(Evas_Object *o, Eina_Bool enable);
Comment 9 Thiago Marcos P. Santos 2012-05-08 02:54:23 PDT
I might be wrong, but this patch is causing this test here to crash:
fast/frames/frame-crash-with-page-cache.html
Comment 10 Thiago Marcos P. Santos 2012-05-08 02:56:36 PDT
(In reply to comment #9)
> I might be wrong, but this patch is causing this test here to crash:
> fast/frames/frame-crash-with-page-cache.html

Yes, it is. I rolled out the patch locally and it doesn't crash. I'm gonna open a bug for that.