Bug 85402

Summary: Childlist mutations in shadow DOM should be observable with MutationObservers
Product: WebKit Reporter: Adam Klein <adamk>
Component: New BugsAssignee: Adam Klein <adamk>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, ojan, rafaelw, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 68729    
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch with more tests none

Adam Klein
Reported 2012-05-02 12:25:50 PDT
Childlist mutations in shadow DOM should be observable with MutationObservers
Attachments
Patch (7.17 KB, patch)
2012-05-02 12:29 PDT, Adam Klein 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.22 KB, patch)
2012-05-02 12:37 PDT, Adam Klein 		no flags
DetailsFormatted DiffDiff
Patch with more tests (7.90 KB, patch)
2012-05-02 14:00 PDT, Adam Klein 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adam Klein
Comment 1 2012-05-02 12:29:08 PDT
Created attachment 139859 [details] Patch
Adam Klein
Comment 2 2012-05-02 12:37:43 PDT
Created attachment 139860 [details] Patch for landing
Dimitri Glazkov (Google)
Comment 3 2012-05-02 12:45:12 PDT
Comment on attachment 139860 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=139860&action=review > Source/WebCore/ChangeLog:13 > + This patch moves code around to properly notify when childlist are > + mutated in shadow DOM and covers that change with a new test. This doesn't leak elements in the shadow DOM subtree out to the document, right? Do we need a test for this?
Adam Klein
Comment 4 2012-05-02 13:22:37 PDT
(In reply to comment #3) > (From update of attachment 139860 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=139860&action=review > > > Source/WebCore/ChangeLog:13 > > + This patch moves code around to properly notify when childlist are > > + mutated in shadow DOM and covers that change with a new test. > > This doesn't leak elements in the shadow DOM subtree out to the document, right? Do we need a test for this? No leakage, since we just walk up the parent change to find subtree listeners. Sounds like a good test to have, though.
Adam Klein
Comment 5 2012-05-02 14:00:01 PDT
Created attachment 139881 [details] Patch with more tests
WebKit Review Bot
Comment 6 2012-05-02 15:03:33 PDT
Comment on attachment 139881 [details] Patch with more tests Clearing flags on attachment: 139881 Committed r115897: <http://trac.webkit.org/changeset/115897>
WebKit Review Bot
Comment 7 2012-05-02 15:03:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.