Bug 85363

Summary: [EFL] Enable blob support for the EFL port
Product: WebKit Reporter: Sudarsana Nagineni (babu) <naginenis>
Component: WebKit EFLAssignee: Sudarsana Nagineni (babu) <naginenis>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 87498    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Sudarsana Nagineni (babu) 2012-05-02 04:07:20 PDT 
Turn on blob support for the EFL port.
Comment 1 Sudarsana Nagineni (babu) 2012-05-25 08:15:12 PDT 
Created attachment 144073 [details]
Patch

Enable Blob support by default.
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-05-25 16:02:11 PDT 
Comment on attachment 144073 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144073&action=review

> LayoutTests/ChangeLog:10
> +        * platform/efl/test_expectations.txt:

IIRC there are also quite a few blob-related tests in Skipped. Have you checked if any of them passes now?
Comment 3 Sudarsana Nagineni (babu) 2012-05-26 02:17:18 PDT 
(In reply to comment #2)
> > LayoutTests/ChangeLog:10
> > +        * platform/efl/test_expectations.txt:
> 
> IIRC there are also quite a few blob-related tests in Skipped. Have you checked if any of them passes now?

I checked some of the blob related tests which are under beginDragWithFiles section in Skipped file and they are still failing. It seems there are few more tests which needs to be checked. I'm going to do that and update the patch based on the results.
Comment 4 Sudarsana Nagineni (babu) 2012-05-26 02:38:00 PDT 
Created attachment 144198 [details]
Patch

Unskip passing tests from Skipped file.
Comment 5 Sudarsana Nagineni (babu) 2012-05-26 02:44:35 PDT 
Created attachment 144199 [details]
Patch

Updated changelog.
Comment 6 Hajime Morrita 2012-05-27 19:00:41 PDT 
Comment on attachment 144199 [details]
Patch

rubberstamping.
Comment 7 Gyuyoung Kim 2012-05-27 21:01:22 PDT 
Comment on attachment 144199 [details]
Patch

Looks good to me.
Comment 8 WebKit Review Bot 2012-05-27 22:00:45 PDT 
Comment on attachment 144199 [details]
Patch

Clearing flags on attachment: 144199

Committed r118647: <http://trac.webkit.org/changeset/118647>
Comment 9 WebKit Review Bot 2012-05-27 22:00:50 PDT 
All reviewed patches have been landed.  Closing bug.