Bug 85207

Summary: [V8][JSC] Remove hard-coded "Not enough arguments" errors
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric.carlson, feature-media-reviews, gustavo, japhet, kbr, pnormand, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 84074    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Kentaro Hara
Reported 2012-04-30 10:46:11 PDT
In bug 85022 and bug 85097, we implemented createNotEnoughArgumentsError() in JSC and V8Proxy::throwNotEnoughArgumentsError() in V8 and partially removed hard-coded "Not enough arguments" errors. In this bug, we remove hard-coded "Not enough arguments" errors by using the helper methods.
Attachments
Patch (10.07 KB, patch)
2012-04-30 10:49 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Patch (10.09 KB, patch)
2012-04-30 10:58 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Patch (10.09 KB, patch)
2012-04-30 11:07 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-04-30 10:49:26 PDT
Created attachment 139476 [details] Patch
Early Warning System Bot
Comment 2 2012-04-30 10:54:12 PDT
Comment on attachment 139476 [details] Patch Attachment 139476 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12584341
Philippe Normand
Comment 3 2012-04-30 10:54:30 PDT
Comment on attachment 139476 [details] Patch Attachment 139476 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12584344
Early Warning System Bot
Comment 4 2012-04-30 10:57:24 PDT
Comment on attachment 139476 [details] Patch Attachment 139476 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12590287
Kentaro Hara
Comment 5 2012-04-30 10:58:26 PDT
Created attachment 139478 [details] Patch
Early Warning System Bot
Comment 6 2012-04-30 11:02:48 PDT
Comment on attachment 139478 [details] Patch Attachment 139478 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12585342
Philippe Normand
Comment 7 2012-04-30 11:03:41 PDT
Comment on attachment 139478 [details] Patch Attachment 139478 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12595218
Early Warning System Bot
Comment 8 2012-04-30 11:04:04 PDT
Comment on attachment 139478 [details] Patch Attachment 139478 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12598117
Kentaro Hara
Comment 9 2012-04-30 11:07:48 PDT
Created attachment 139483 [details] Patch
WebKit Review Bot
Comment 10 2012-04-30 14:36:35 PDT
Comment on attachment 139483 [details] Patch Clearing flags on attachment: 139483 Committed r115670: <http://trac.webkit.org/changeset/115670>
WebKit Review Bot
Comment 11 2012-04-30 14:36:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.