Bug 85112

Summary:

Add &lrm; &rlm; and   to WebVTT parser

Product:

WebKit

Reporter:

Anna Cavender <annacc>

Component:

Media

Assignee:

Eric Carlson <eric.carlson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ddkilzer, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, jer.noble

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

85035

Attachments:

Description	Flags
Proposed patch	none

Description Anna Cavender 2012-04-27 17:07:17 PDT

&lrm; &rlm; and &nbsp; were recently added to the WebVTT spec

http://dev.w3.org/html5/webvtt/#webvtt-cue-components

Comment 1 David Kilzer (:ddkilzer) 2014-01-18 19:47:11 PST

Fixed in Blink:  http://src.chromium.org/viewvc/blink?view=revision&revision=161822

Comment 2 David Kilzer (:ddkilzer) 2014-01-18 19:47:23 PST

(In reply to comment #1)
> Fixed in Blink:  http://src.chromium.org/viewvc/blink?view=revision&revision=161822

https://code.google.com/p/chromium/issues/detail?id=314028

Comment 3 Eric Carlson 2014-01-20 15:15:46 PST

I have had changes for this in my local repository for a while, guess I forgot to post a patch.

Comment 4 Eric Carlson 2014-01-20 15:17:43 PST

Created attachment 221697 [details]
Proposed patch

Comment 5 Eric Carlson 2014-01-21 08:02:59 PST

Doesn't look like the efl failure has anything to do with this patch:

Last 500 characters of output:
ing CXX object Source/WebCore/CMakeFiles/WebCore.dir/dom/ScriptedAnimationController.cpp.o
c++: internal compiler error: Killed (program cc1plus)

Comment 6 Jer Noble 2014-01-21 09:54:14 PST

Comment on attachment 221697 [details]
Proposed patch

r=me

Comment 7 WebKit Commit Bot 2014-01-21 10:39:41 PST

Comment on attachment 221697 [details]
Proposed patch

Clearing flags on attachment: 221697

Committed r162450: <http://trac.webkit.org/changeset/162450>

Comment 8 WebKit Commit Bot 2014-01-21 10:39:43 PST

All reviewed patches have been landed.  Closing bug.