Bug 85051

Summary: Fix repetitions & by animation support for SVGAnimateTransformElement
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: SVGAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal CC: zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 84968    
Bug Blocks: 41761, 36729, 85133    
Attachments:
Description Flags
Patch
none
Patch v2 koivisto: review+

Nikolas Zimmermann
Reported 2012-04-27 04:47:08 PDT
Repetitions are currently handled by adjusting percentage (percentage += repeatCount). This doesn't work for <animateTransform> as each repetition has to be post-multiplied to the animated transform list. By-animations are equal to values="0;by" animations in SMIL. 0 is the neutral element of addition, which is the _zero_ matrix, not the identity matrix for SVGTransform. See moz guys discussing the same problem, with the same outcome: http://brian.sol1.net/svg/animatetransform-issues/by-animation-and-scale-transformations/
Attachments
Patch (69.79 KB, patch)
2012-04-27 04:54 PDT, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Patch v2 (69.74 KB, patch)
2012-04-27 06:59 PDT, Nikolas Zimmermann 		koivisto: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2012-04-27 04:54:53 PDT
Created attachment 139171 [details] Patch
Early Warning System Bot
Comment 2 2012-04-27 05:00:53 PDT
Comment on attachment 139171 [details] Patch Attachment 139171 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12557170
Early Warning System Bot
Comment 3 2012-04-27 05:03:50 PDT
Comment on attachment 139171 [details] Patch Attachment 139171 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12556176
Build Bot
Comment 4 2012-04-27 05:08:47 PDT
Comment on attachment 139171 [details] Patch Attachment 139171 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12551178
Nikolas Zimmermann
Comment 5 2012-04-27 06:58:42 PDT
Uploading patch v2, which will fix the release builds.
Nikolas Zimmermann
Comment 6 2012-04-27 06:59:36 PDT
Created attachment 139192 [details] Patch v2
Antti Koivisto
Comment 7 2012-04-27 07:02:51 PDT
Comment on attachment 139192 [details] Patch v2 r=me
Nikolas Zimmermann
Comment 8 2012-04-27 07:10:22 PDT
Committed r115425: <http://trac.webkit.org/changeset/115425>
Note You need to log in before you can comment on or make changes to this bug.