Bug 84963

Summary: [EFL] Fix the build with DRAG_SUPPORT disabled.
Product: WebKit Reporter: Raphael Kubo da Costa (:rakuco) <rakuco>
Component: WebKit EFLAssignee: Raphael Kubo da Costa (:rakuco) <rakuco>
Status: RESOLVED FIXED    
Severity: Normal CC: d-r, gyuyoung.kim, lucas.de.marchi, tmpsantos, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 84952    
Attachments:
Description Flags
Patch tonikitoo: review+

Raphael Kubo da Costa (:rakuco)
Reported 2012-04-26 08:07:20 PDT
[EFL] Fix the build with DRAG_SUPPORT disabled.
Attachments
Patch (1.89 KB, patch)
2012-04-26 08:08 PDT, Raphael Kubo da Costa (:rakuco) 		tonikitoo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Raphael Kubo da Costa (:rakuco)
Comment 1 2012-04-26 08:08:34 PDT
Created attachment 139004 [details] Patch
Raphael Kubo da Costa (:rakuco)
Comment 2 2012-04-26 08:15:05 PDT
Committed r115318: <http://trac.webkit.org/changeset/115318>
Dominik Röttsches (drott)
Comment 3 2012-04-27 00:44:30 PDT
After build 706 on the Debug buildbot which had the DRAG support change, as well as the scrolling changes for CMake http://build.webkit.org/builders/EFL%20Linux%20Debug/builds/706 we see a couple of new failures: fast/css/user-drag-none.html fast/events/autoscroll-nonscrollable-iframe-in-scrollable-div.html fast/events/autoscroll-should-not-stop-on-keypress.html fast/forms/select-multiple-elements-with-mouse-drag.html fast/repaint/repaint-across-writing-mode-boundary.html fast/repaint/selection-rl.html fast/text/reset-drag-on-mouse-down.html fast/writing-mode/horizontal-bt-replaced-selection.html fast/writing-mode/vertical-lr-replaced-selection.html fast/writing-mode/vertical-rl-replaced-selection.html
Thiago Marcos P. Santos
Comment 4 2012-04-27 00:48:32 PDT
(In reply to comment #3) > After build 706 on the Debug buildbot which had the DRAG support change, as well as the scrolling changes for CMake > http://build.webkit.org/builders/EFL%20Linux%20Debug/builds/706 > we see a couple of new failures: > > fast/css/user-drag-none.html > fast/events/autoscroll-nonscrollable-iframe-in-scrollable-div.html > fast/events/autoscroll-should-not-stop-on-keypress.html > fast/forms/select-multiple-elements-with-mouse-drag.html > fast/repaint/repaint-across-writing-mode-boundary.html > fast/repaint/selection-rl.html > fast/text/reset-drag-on-mouse-down.html > fast/writing-mode/horizontal-bt-replaced-selection.html > fast/writing-mode/vertical-lr-replaced-selection.html > fast/writing-mode/vertical-rl-replaced-selection.html I'm investigating if those tests are really failing or if they just need rebaselining.
Thiago Marcos P. Santos
Comment 5 2012-04-27 03:15:00 PDT
I had to remove the CMakeCache.txt from the bot. Failure count is back to normal.
Note You need to log in before you can comment on or make changes to this bug.