Bug 84952

Summary: [BlackBerry] properly disable DRAG_SUPPORT
Product: WebKit Reporter: Antonio Gomes <tonikitoo>
Component: Tools / TestsAssignee: Antonio Gomes <tonikitoo>
Status: RESOLVED FIXED    
Severity: Normal CC: dbates, mxie, paroga, rakuco, rwlbuis, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 84963    
Bug Blocks:    
Attachments:
Description Flags
patch
gyuyoung.kim: commit-queue-
(r115348, r=dbates) patch v2 - fixed EFL build dbates: review+

Description Antonio Gomes 2012-04-26 06:52:39 PDT 
We were hardcoding "ENABLE_DRAG_SUPPORT 0" in Platform.h

We should do it with CMake's help instead.
Comment 1 Antonio Gomes 2012-04-26 07:00:05 PDT 
Created attachment 138994 [details]
patch
Comment 2 Gyuyoung Kim 2012-04-26 07:51:33 PDT 
Comment on attachment 138994 [details]
patch

Attachment 138994 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/12517943
Comment 3 Antonio Gomes 2012-04-26 08:09:50 PDT 
Created attachment 139005 [details]
(r115348, r=dbates) patch v2 - fixed EFL build
Comment 4 Antonio Gomes 2012-04-26 10:36:22 PDT 
@paroga, with patch we have to manually enable DRAG support in options{WinCE,Win}.cmake files. Are you ok with that?
Comment 5 Daniel Bates 2012-04-26 10:41:52 PDT 
Comment on attachment 139005 [details]
(r115348, r=dbates) patch v2 - fixed EFL build

We should probably enable drag support for Windows. Currently, it defaults to off by <http://trac.webkit.org/browser/trunk/Source/cmake/WebKitFeatures.cmake?rev=114113#L30>.

r=me
Comment 6 Antonio Gomes 2012-04-26 13:32:43 PDT 
Comment on attachment 139005 [details]
(r115348, r=dbates) patch v2 - fixed EFL build

Committed: <http://trac.webkit.org/changeset/115348>