Bug 84952

Summary: [BlackBerry] properly disable DRAG_SUPPORT
Product: WebKit Reporter: Antonio Gomes <tonikitoo>
Component: Tools / TestsAssignee: Antonio Gomes <tonikitoo>
Status: RESOLVED FIXED    
Severity: Normal CC: dbates, mxie, paroga, rakuco, rwlbuis, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 84963    
Bug Blocks:    
Attachments:
Description Flags
patch
gyuyoung.kim: commit-queue-
(r115348, r=dbates) patch v2 - fixed EFL build dbates: review+

Antonio Gomes
Reported 2012-04-26 06:52:39 PDT
We were hardcoding "ENABLE_DRAG_SUPPORT 0" in Platform.h We should do it with CMake's help instead.
Attachments
patch (3.51 KB, patch)
2012-04-26 07:00 PDT, Antonio Gomes 		gyuyoung.kim: commit-queue-
DetailsFormatted DiffDiff
(r115348, r=dbates) patch v2 - fixed EFL build (4.29 KB, patch)
2012-04-26 08:09 PDT, Antonio Gomes 		dbates: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antonio Gomes
Comment 1 2012-04-26 07:00:05 PDT
Created attachment 138994 [details] patch
Gyuyoung Kim
Comment 2 2012-04-26 07:51:33 PDT
Comment on attachment 138994 [details] patch Attachment 138994 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/12517943
Antonio Gomes
Comment 3 2012-04-26 08:09:50 PDT
Created attachment 139005 [details] (r115348, r=dbates) patch v2 - fixed EFL build
Antonio Gomes
Comment 4 2012-04-26 10:36:22 PDT
@paroga, with patch we have to manually enable DRAG support in options{WinCE,Win}.cmake files. Are you ok with that?
Daniel Bates
Comment 5 2012-04-26 10:41:52 PDT
Comment on attachment 139005 [details] (r115348, r=dbates) patch v2 - fixed EFL build We should probably enable drag support for Windows. Currently, it defaults to off by <http://trac.webkit.org/browser/trunk/Source/cmake/WebKitFeatures.cmake?rev=114113#L30>. r=me
Antonio Gomes
Comment 6 2012-04-26 13:32:43 PDT
Comment on attachment 139005 [details] (r115348, r=dbates) patch v2 - fixed EFL build Committed: <http://trac.webkit.org/changeset/115348>
Note You need to log in before you can comment on or make changes to this bug.