Bug 84826

Summary: Calendar Picker: Resize to minimal size to fit the content
Product: WebKit Reporter: Kent Tamura <tkent>
Component: FormsAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: haraken, keishi, morrita
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 53961, 85331    
Attachments:
Description Flags
Patch
none
Patch 2 morrita: review+

Kent Tamura
Reported 2012-04-24 22:15:16 PDT
Calendar Picker: Resize to minimal size to fit the content
Attachments
Patch (9.30 KB, patch)
2012-04-24 22:30 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch 2 (9.31 KB, patch)
2012-04-25 00:30 PDT, Kent Tamura 		morrita: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2012-04-24 22:30:09 PDT
Created attachment 138739 [details] Patch
Kent Tamura
Comment 2 2012-04-24 22:32:06 PDT
Keishi, would you do informal review for the patch please?
Kentaro Hara
Comment 3 2012-04-24 22:39:10 PDT
Comment on attachment 138739 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138739&action=review > Source/WebCore/ChangeLog:13 > + The minimal size depends on font settings, localized labels, and > + localizaed formats. So we put objects on a trasparent element, calculate > + minimal size, resize the popup, then show the objects. Does this mean it would be difficult to add pixel tests for the change? I might want to see some test.
Kent Tamura
Comment 4 2012-04-24 22:48:58 PDT
(In reply to comment #3) > (From update of attachment 138739 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=138739&action=review > > > Source/WebCore/ChangeLog:13 > > + The minimal size depends on font settings, localized labels, and > > + localizaed formats. So we put objects on a trasparent element, calculate > > + minimal size, resize the popup, then show the objects. > > Does this mean it would be difficult to add pixel tests for the change? I might want to see some test. No, because we assume test environment is homogeneous. But DRT can't capture the content of popups at all. I have a plain to add tests later. We need to solve Bug 84827.
Keishi Hattori
Comment 5 2012-04-25 00:21:36 PDT
Comment on attachment 138739 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138739&action=review Looks good to me. > Source/WebCore/Resources/calendarPicker.css:52 > + opacity: 0.3; It is impossible to notice for a 0.1s animation, but isn't it better to start completely invisible and set the starting opacity inside the fixWindowSize function?
Kent Tamura
Comment 6 2012-04-25 00:30:46 PDT
Created attachment 138749 [details] Patch 2 initial opacity, and some typos
Kentaro Hara
Comment 7 2012-04-25 00:32:21 PDT
Delegating review to morrita-san.
Hajime Morrita
Comment 8 2012-04-25 17:57:33 PDT
Comment on attachment 138749 [details] Patch 2 Hopes to have tests somehow. rs=me
Kent Tamura
Comment 9 2012-04-25 18:25:20 PDT
Committed r115276: <http://trac.webkit.org/changeset/115276>
Note You need to log in before you can comment on or make changes to this bug.