Summary: | [EFL][DRT] "resource,request,willsend" signal needs to provide more information | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
Component: | WebKit EFL | Assignee: | Chris Dumez <cdumez> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | gyuyoung.kim, gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 81891 | ||||||||
Attachments: |
|
Description
Chris Dumez
2012-04-23 23:15:50 PDT
Created attachment 138497 [details]
Patch
Comment on attachment 138497 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138497&action=review > Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:200 > + redirectResponse = &responseBuffer; I wonder why you don't use redirectResponse directly in order to send messages to application via signal. > Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:201 > + } Add blank line to here. > Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:203 > + It is better to remove blank line. > Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:205 > + ditto. Created attachment 138756 [details]
Patch
Fix blank lines issues.
One more question. Is there any unskip test by this patch? Gyuyoung: No. As explained, the patch is split in several parts (84670, 81891, 84129). On its own, it does not allow unskipping test cases. Comment on attachment 138756 [details] Patch Clearing flags on attachment: 138756 Committed r115294: <http://trac.webkit.org/changeset/115294> All reviewed patches have been landed. Closing bug. |