Bug 84607

Summary: Cut dependency on RenderLayer::scrollRectToVisible outside rendering
Product: WebKit Reporter: Julien Chaffraix <jchaffraix>
Component: Layout and RenderingAssignee: Julien Chaffraix <jchaffraix>
Status: RESOLVED FIXED    
Severity: Normal CC: jamesr, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 83811    
Attachments:
Description Flags
Proposed fix 1: Add RenderObject::scrollRectToVisible. none

Julien Chaffraix
Reported 2012-04-23 09:59:04 PDT
Currently the logic assumes that there is a RenderLayer to handle a scrollRectToVisible action as it needs to query the enclosing RenderLayer. This exposes RenderLayer to the non-rendering code, thus exposing needlessly a rendering-only concept. Patch forthcoming.
Attachments
Proposed fix 1: Add RenderObject::scrollRectToVisible. (14.19 KB, patch)
2012-04-23 10:23 PDT, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Julien Chaffraix
Comment 1 2012-04-23 10:23:22 PDT
Created attachment 138376 [details] Proposed fix 1: Add RenderObject::scrollRectToVisible.
WebKit Review Bot
Comment 2 2012-04-23 16:49:55 PDT
Comment on attachment 138376 [details] Proposed fix 1: Add RenderObject::scrollRectToVisible. Clearing flags on attachment: 138376 Committed r114962: <http://trac.webkit.org/changeset/114962>
WebKit Review Bot
Comment 3 2012-04-23 16:50:07 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.