Bug 84486

Summary: Crash in getOrDrawNodeHighlight after r114659
Product: WebKit Reporter: Xianzhu Wang <wangxianzhu>
Component: Web Inspector (Deprecated)Assignee: Xianzhu Wang <wangxianzhu>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, jer.noble, pfeldman
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
dbates: review+
patch for landing dbates: commit-queue-

Description Xianzhu Wang 2012-04-20 13:27:52 PDT 
See crbug.com/124382.
Comment 1 Xianzhu Wang 2012-04-20 13:52:32 PDT 
Created attachment 138155 [details]
patch
Comment 2 Jer Noble 2012-04-20 14:18:04 PDT 
*** Bug 84492 has been marked as a duplicate of this bug. ***
Comment 3 Jer Noble 2012-04-20 14:22:21 PDT 
Comment on attachment 138155 [details]
patch

Looks good to me.  After applying the patch, the crash no longer occurs on that test.
Comment 4 Jer Noble 2012-04-20 14:29:17 PDT 
And by "that test", I mean inspector/elements/elements-panel-selection-on-refresh.html, which was the crashing test in bug 84492, which was marked as a dup of this bug.
Comment 5 Daniel Bates 2012-04-20 14:30:11 PDT 
Comment on attachment 138155 [details]
patch

Looks good to me.

For completeness, Jer Noble told me on IRC that the test case inspector/elements/elements-panel-selection-on-refresh.html covers this crash.
Comment 6 Daniel Bates 2012-04-20 14:31:34 PDT 
Comment on attachment 138155 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=138155&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests. Just a quick fix of a crash caused by r114659.

Per comment 5, I suggest that we mention that this fix is covered by test inspector/elements/elements-panel-selection-on-refresh.html.
Comment 7 Xianzhu Wang 2012-04-20 14:35:50 PDT 
Created attachment 138167 [details]
patch for landing

Test case mentioned in ChangeLog. Thanks for review!
Comment 8 Jer Noble 2012-04-20 14:38:17 PDT 
Committed r114783: <http://trac.webkit.org/changeset/114783>
Comment 9 Daniel Bates 2012-04-20 14:39:29 PDT 
Comment on attachment 138167 [details]
patch for landing

cq-'ing this patch since it landed in <http://trac.webkit.org/changeset/114783>.
Comment 10 Jer Noble 2012-04-20 14:39:58 PDT 
(In reply to comment #7)
> Created an attachment (id=138167) [details]
> patch for landing
> 
> Test case mentioned in ChangeLog. Thanks for review!

Landed this patch manually.  (I updated the ChangeLog to mention the crashing test, so my wording is not exactly the same as your most recently uploaded patch, but the meaning is there.) :)