Summary: | media-exit-fullscreen-button (and related enums) is unnecessary and should be removed. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||
Component: | Media | Assignee: | Jer Noble <jer.noble> | ||||
Status: | REOPENED --- | ||||||
Severity: | Normal | CC: | ahmad.saleem792, destra, eric.carlson, jer.noble, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 84515 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Jer Noble
2012-04-17 10:26:19 PDT
That keyword was added in http://trac.webkit.org/changeset/111041 for (bug #70437). The state of the full screen button does not need to be reflected in CSS. Created attachment 137580 [details]
Patch
Comment on attachment 137580 [details] Patch Rejecting attachment 137580 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: y/autoinstalled/mechanize/_urllib2_fork.py", line 332, in _call_chain result = func(*args) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open return self.do_open(conn_factory, req) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open raise URLError(err) urllib2.URLError: <urlopen error [Errno 113] No route to host> Full output: http://queues.webkit.org/results/12476285 Committed r114789: <http://trac.webkit.org/changeset/114789> Rolled out commit in r114804. Committed r114804: <http://trac.webkit.org/changeset/114804> Reopening after rollout. I didn't manage to find anything with this 'media-exit-fullscreen-button' except some tests in CSSOM and 'js' file for Developer Tools. I think we don't have these anymore and we can close this bug. CCing - Eric, Dana and Jer Noble. |