Bug 84129

Summary: [EFL] ResourceError domain needs to be properly set in FrameLoaderClient
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit EFLAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 81891    
Bug Blocks: 82704    
Attachments:
Description Flags
Proposed patch
japhet: review+
Patch none

Description Chris Dumez 2012-04-17 00:28:48 PDT
Currently, EFL's FrameLoaderClient sets the ResourceError's domain to "Error", no matter what kind of error it is.
The ResourceError's needs to be appropriately set so that it is possible to distinguish NSURL errors from WebKit errors.

This functionality is needed in the DumpRenderTree to generate correct output for LayoutTestController's dumpResourceLoadCallbacks().
Comment 1 Chris Dumez 2012-04-17 04:50:24 PDT
Created attachment 137515 [details]
Proposed patch
Comment 2 Chris Dumez 2012-04-27 03:12:08 PDT
Comment on attachment 137515 [details]
Proposed patch

Clear cq? flag since the patch needs rebasing.
Comment 3 Gyuyoung Kim 2012-04-27 03:15:47 PDT
Yes, plz submit rebased patch again. Request only cq?. In addition, write reviewer name in changelog.
Comment 4 Chris Dumez 2012-04-27 03:21:27 PDT
Created attachment 139162 [details]
Patch

Patch for landing.
Comment 5 WebKit Review Bot 2012-04-27 11:05:14 PDT
Comment on attachment 139162 [details]
Patch

Clearing flags on attachment: 139162

Committed r115451: <http://trac.webkit.org/changeset/115451>
Comment 6 WebKit Review Bot 2012-04-27 11:05:19 PDT
All reviewed patches have been landed.  Closing bug.