Bug 84090

Summary: Refactor windowClipRectForLayer to remove the explicit RenderLayer dependency
Product: WebKit Reporter: Julien Chaffraix <jchaffraix>
Component: Layout and RenderingAssignee: Julien Chaffraix <jchaffraix>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric, gustavo, pnormand, simon.fraser, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 83811    
Attachments:
Description Flags
Proposed renaming / API change 1.
none
Proposed renaming / API change 2: fixed platforms compiling PluginView.
none
Proposed change 3: Fixed EmbeddedWidget for win. none

Julien Chaffraix
Reported 2012-04-16 15:46:22 PDT
windowClipRectForLayer is not a general purpose function as its name would imply. It's actually used only to get an HTMLFrameOwner clip rect. For clarity it could be renamed and also we could remove the unneeded dependency on RenderLayer.
Attachments
Proposed renaming / API change 1. (12.10 KB, patch)
2012-04-16 16:02 PDT, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
Proposed renaming / API change 2: fixed platforms compiling PluginView. (15.93 KB, patch)
2012-04-16 19:21 PDT, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
Proposed change 3: Fixed EmbeddedWidget for win. (18.21 KB, patch)
2012-04-17 09:41 PDT, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Julien Chaffraix
Comment 1 2012-04-16 16:02:45 PDT
Created attachment 137423 [details] Proposed renaming / API change 1.
Build Bot
Comment 2 2012-04-16 16:27:38 PDT
Comment on attachment 137423 [details] Proposed renaming / API change 1. Attachment 137423 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12416323
Early Warning System Bot
Comment 3 2012-04-16 16:41:22 PDT
Comment on attachment 137423 [details] Proposed renaming / API change 1. Attachment 137423 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12415442
Philippe Normand
Comment 4 2012-04-16 17:00:43 PDT
Comment on attachment 137423 [details] Proposed renaming / API change 1. Attachment 137423 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12417290
Julien Chaffraix
Comment 5 2012-04-16 19:21:46 PDT
Created attachment 137458 [details] Proposed renaming / API change 2: fixed platforms compiling PluginView.
Build Bot
Comment 6 2012-04-16 19:45:21 PDT
Comment on attachment 137458 [details] Proposed renaming / API change 2: fixed platforms compiling PluginView. Attachment 137458 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12423011
Julien Chaffraix
Comment 7 2012-04-17 09:41:02 PDT
Created attachment 137549 [details] Proposed change 3: Fixed EmbeddedWidget for win.
Dave Hyatt
Comment 8 2012-05-07 14:11:02 PDT
Comment on attachment 137549 [details] Proposed change 3: Fixed EmbeddedWidget for win. Looks good. r=me
WebKit Review Bot
Comment 9 2012-05-07 16:33:12 PDT
Comment on attachment 137549 [details] Proposed change 3: Fixed EmbeddedWidget for win. Clearing flags on attachment: 137549 Committed r116371: <http://trac.webkit.org/changeset/116371>
WebKit Review Bot
Comment 10 2012-05-07 16:33:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.