Summary: | [Chromium] Enable INPUT_TYPE_DATE | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kent Tamura <tkent> | ||||
Component: | Forms | Assignee: | Kent Tamura <tkent> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | haraken, morrita, peter, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 19264, 83852 | ||||||
Attachments: |
|
Description
Kent Tamura
2012-04-12 02:08:11 PDT
Created attachment 136858 [details]
Patch
Comment on attachment 136858 [details]
Patch
Wouldn't there be any concern about enabling INPUT_TYPE_DATE? (I am not familiar with the consensus.)
I can imagine that quite some code (rendering/JavaScript/CSS as well) is going to be shared for the different date and time UIs, wouldn't it be better to wait for it to mature a bit? Is there a run-time flag for the functionality? Input types such as "date" and "month"/"week" are rather similar, it may confuse web developers when certain types work, but others don't. H> Wouldn't there be any concern about enabling INPUT_TYPE_DATE? (I am not familiar with the consensus.) P> I can imagine that quite some code (rendering/JavaScript/CSS as well) is going to be shared for the different date and time UIs, wouldn't it be better to wait for it to mature a bit? P> Is there a run-time flag for the functionality? Input types such as "date" and "month"/"week" are rather similar, it may confuse web developers when certain types work, but others don't. I don't think we should enable all the types at once. I'd like to ship available types one by one. We need some months to implement other date/time types. The date type still have small UI issues. I'd like to enable it now and have feedbacks. If we couldn't make it mature before M20 branch, I'll introduce a runtime flag and disable it by default. Issues: * RTL: Bug 83668 * No keyboard-binding to open a calendar picker * default placeholder to indicate the format Comment on attachment 136858 [details]
Patch
rs=me based on tkent's comment.
Comment on attachment 136858 [details] Patch Clearing flags on attachment: 136858 Committed r113972: <http://trac.webkit.org/changeset/113972> All reviewed patches have been landed. Closing bug. Anyway I'll introduce a runtime flag to disable this easily. |