Implement DataList UI for chromium

• Component: Forms
• Status: RESOLVED FIXED

[Keishi Hattori]

Show datalist suggestions in a popup

[Keishi Hattori]

Created attachment 136823 [details]
Patch

[Keishi Hattori]

isherman@ reviewed it
http://codereview.chromium.org/10037002/

chromium part is here
http://codereview.chromium.org/10024059/

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[WebKit Review Bot]

Attachment 136823 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/ChangeLog', u'Sourc..." exit_code: 1
Source/WebKit/chromium/src/AutofillPopupMenuClient.cpp:102:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebKit/chromium/src/WebInputElement.cpp:39:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/chromium/public/WebInputElement.h:42:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 3 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Keishi Hattori]

Oops, I uploaded an old patch. I will upload a new one.

[Kent Tamura]

Comment on attachment 136823 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136823&action=review

> Source/WebKit/chromium/ChangeLog:8
> +        Implement DataList UI for chromium
> +        https://bugs.webkit.org/show_bug.cgi?id=83742
> +
> +        Expose HTMLDataListElement in the WebKitAPI.
> +        Introduce MenuItemIDs.
> +

This patch doesn't implement the UI, do it? The summary looks not concrete.

I think adding WebDataListElement and the autofill-related changes should be separated patches.
Also, you should explain why you'd like to make these changes in ChangeLog.

> Source/WebKit/chromium/public/WebAutofillClient.h:36
> +enum {

This should be put inside of WebAutofillClient class.

> Source/WebKit/chromium/public/WebAutofillClient.h:62
> -                                             int uniqueID,
> +                                             int itemID,

You have to update the explanation of uniqueID in the comment.

> Source/WebKit/chromium/public/WebDataListElement.h:44
> +// Provides readonly access to some properties of a DOM input element node.

input -> datalist

[Keishi Hattori]

Created attachment 136849 [details]
Patch

[WebKit Review Bot]

Comment on attachment 136849 [details]
Patch

Attachment 136849 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12387587

[Keishi Hattori]

Created attachment 136897 [details]
Reverted indentation fix

Complete newbie to webkit bugzilla here, so I hope I'm not committing any transgressions.  Thanks so much for all your work on this.  Just wanted to point out that this doesn't seem to be working for input elements with the 'email' type (but does for those with 'tel', 'url', or 'search').

[Keishi Hattori]

(In reply to comment #10)
> Complete newbie to webkit bugzilla here, so I hope I'm not committing any transgressions.  Thanks so much for all your work on this.  Just wanted to point out that this doesn't seem to be working for input elements with the 'email' type (but does for those with 'tel', 'url', or 'search').

Thanks! Datalist for email type is disabled intensionally because we are still working on it.
https://bugs.webkit.org/show_bug.cgi?id=84346

(In reply to comment #11)
> (In reply to comment #10)
> > Complete newbie to webkit bugzilla here, so I hope I'm not committing any transgressions.  Thanks so much for all your work on this.  Just wanted to point out that this doesn't seem to be working for input elements with the 'email' type (but does for those with 'tel', 'url', or 'search').
> 
> Thanks! Datalist for email type is disabled intensionally because we are still working on it.
> https://bugs.webkit.org/show_bug.cgi?id=84346

Ah, apologies for missing that.  Thanks!

[Kent Tamura]

done