Bug 83762 - [Chromium] Add WebKit API to access <datalist> options
Summary: [Chromium] Add WebKit API to access <datalist> options
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keishi Hattori
URL:
Keywords:
Depends on:
Blocks: 83742
  Show dependency treegraph
 
Reported: 2012-04-12 02:15 PDT by Keishi Hattori
Modified: 2012-04-16 14:27 PDT (History)
8 users (show)

See Also:


Attachments
Patch (13.82 KB, patch)
2012-04-12 04:50 PDT, Keishi Hattori
no flags Details | Formatted Diff | Diff
Patch (13.83 KB, patch)
2012-04-12 05:24 PDT, Keishi Hattori
tkent: review-
Details | Formatted Diff | Diff
Reverted indentation fix (8.53 KB, patch)
2012-04-12 06:56 PDT, Keishi Hattori
tkent: review-
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Used WebInputElement::dataListOptions (3.25 KB, patch)
2012-04-13 01:04 PDT, Keishi Hattori
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keishi Hattori 2012-04-12 02:15:57 PDT
Introduce WebDataListElement and expose HTMLDataListElement to chromium.
Comment 1 Keishi Hattori 2012-04-12 04:50:43 PDT
Created attachment 136877 [details]
Patch
Comment 2 WebKit Review Bot 2012-04-12 04:54:20 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Keishi Hattori 2012-04-12 05:24:13 PDT
Created attachment 136882 [details]
Patch
Comment 4 Kent Tamura 2012-04-12 06:34:20 PDT
Comment on attachment 136882 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136882&action=review

r- because of unrelated indentation fix.

> Source/WebKit/chromium/ChangeLog:14
> +        * public/WebInputElement.h: Fix indentation.

Please do not fix indentation in this patch.

> Source/WebKit/chromium/public/WebInputElement.h:90
> +    WEBKIT_EXPORT WebDataListElement dataList() const;
> +

We won't need WebDataListElement if we introduce just "WebNodeCollection dataListOptions()" to WebInputElement.  What do you think?
Comment 5 Keishi Hattori 2012-04-12 06:50:14 PDT
Comment on attachment 136882 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136882&action=review

>> Source/WebKit/chromium/public/WebInputElement.h:90
>> +
> 
> We won't need WebDataListElement if we introduce just "WebNodeCollection dataListOptions()" to WebInputElement.  What do you think?

Do we add HTMLInputElement::dataListOptions()? or are we allowed to implement it in WebInputElement.cpp?
Comment 6 Keishi Hattori 2012-04-12 06:56:09 PDT
Created attachment 136898 [details]
Reverted indentation fix
Comment 7 WebKit Review Bot 2012-04-12 07:52:19 PDT
Comment on attachment 136898 [details]
Reverted indentation fix

Attachment 136898 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12392425
Comment 8 Kent Tamura 2012-04-12 18:26:00 PDT
(In reply to comment #5)
> Do we add HTMLInputElement::dataListOptions()? or are we allowed to implement it in WebInputElement.cpp?

The latter is ok.
Comment 9 Kent Tamura 2012-04-12 18:27:23 PDT
Comment on attachment 136898 [details]
Reverted indentation fix

r- because of a build failure
Comment 10 Keishi Hattori 2012-04-13 01:04:30 PDT
Created attachment 137055 [details]
Used WebInputElement::dataListOptions
Comment 11 WebKit Review Bot 2012-04-13 01:07:12 PDT
Attachment 137055 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/ChangeLog', u'Sourc..." exit_code: 1
Source/WebKit/chromium/public/WebInputElement.h:42:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 12 Kent Tamura 2012-04-13 01:11:35 PDT
Comment on attachment 137055 [details]
Used WebInputElement::dataListOptions

Looks reasonable.
Comment 13 WebKit Review Bot 2012-04-13 04:09:49 PDT
Comment on attachment 137055 [details]
Used WebInputElement::dataListOptions

Clearing flags on attachment: 137055

Committed r114108: <http://trac.webkit.org/changeset/114108>
Comment 14 WebKit Review Bot 2012-04-13 04:09:54 PDT
All reviewed patches have been landed.  Closing bug.