Bug 83590

Summary:

Update cmakeconfig.h.in after r113570

Product:

WebKit

Reporter:

Patrick R. Gansterer <paroga>

Component:

Tools / Tests

Assignee:

Patrick R. Gansterer <paroga>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

charles.wei, dbates, mxie, ossy, rakuco, rwlbuis, tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

72815

Bug Blocks:

Attachments:

Description	Flags
Patch	gyuyoung.kim: commit-queue-
Patch	none
Patch	rwlbuis: review+, dbates: commit-queue-

Patrick R. Gansterer

Reported 2012-04-10 10:03:05 PDT

Update cmakeconfig.h.in after r113570

Attachments
Patch (4.16 KB, patch) 2012-04-10 10:05 PDT, Patrick R. Gansterer	gyuyoung.kim: commit-queue-	Details Formatted Diff Diff
Patch (4.19 KB, patch) 2012-04-10 10:29 PDT, Patrick R. Gansterer	no flags	Details Formatted Diff Diff
Patch (4.15 KB, patch) 2012-04-10 10:32 PDT, Patrick R. Gansterer	rwlbuis: review+ dbates: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Patrick R. Gansterer

Comment 1 2012-04-10 10:05:55 PDT

Created attachment 136477 [details] Patch

Daniel Bates

Comment 2 2012-04-10 10:24:06 PDT

Comment on attachment 136477 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136477&action=review > Source/cmakeconfig.h.cmake:-21 > -#cmakedefine01 ENABLE_DRT This is used by the BlackBerry port. > Source/cmakeconfig.h.cmake:-65 > -#cmakedefine01 ENABLE_VIEWPORT_REFLOW Ditto.

Patrick R. Gansterer

Comment 3 2012-04-10 10:29:22 PDT

Created attachment 136485 [details] Patch

Patrick R. Gansterer

Comment 4 2012-04-10 10:30:17 PDT

(In reply to comment #2) > (From update of attachment 136477 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=136477&action=review > > > Source/cmakeconfig.h.cmake:-21 > > -#cmakedefine01 ENABLE_DRT > > This is used by the BlackBerry port. > > > Source/cmakeconfig.h.cmake:-65 > > -#cmakedefine01 ENABLE_VIEWPORT_REFLOW > > Ditto. Sorry, missed the Blackberry specific ones. Fixed now.

Patrick R. Gansterer

Comment 5 2012-04-10 10:32:36 PDT

Created attachment 136486 [details] Patch

Rob Buis

Comment 6 2012-04-10 10:35:45 PDT

Comment on attachment 136477 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136477&action=review > Source/cmakeconfig.h.cmake:-26 > -#cmakedefine01 ENABLE_FIXED_REPORTED_SIZE This is also used by the BlackBerry port. > Source/cmakeconfig.h.cmake:-53 > -#cmakedefine01 ENABLE_OVERFLOW_SCROLLING Ditto.

Daniel Bates

Comment 7 2012-04-10 10:36:23 PDT

Comment on attachment 136486 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136486&action=review > Source/cmakeconfig.h.cmake:-15 > -#cmakedefine01 ENABLE_CLIENT_BASED_GEOLOCATION According to <https://bugs.webkit.org/show_bug.cgi?id=82594#c4> this is still used by the BlackBerry port. > Source/cmakeconfig.h.cmake:-26 > -#cmakedefine01 ENABLE_FIXED_REPORTED_SIZE This is used by the BlackBerry port. (Added in changeset 112654; <http://trac.webkit.org/changeset/112654/trunk/Source/cmakeconfig.h.cmake>) > Source/cmakeconfig.h.cmake:-53 > -#cmakedefine01 ENABLE_OVERFLOW_SCROLLING Ditto.

Rob Buis

Comment 8 2012-04-10 10:36:38 PDT

Comment on attachment 136486 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136486&action=review > Source/cmakeconfig.h.cmake:-26 > -#cmakedefine01 ENABLE_FIXED_REPORTED_SIZE This is used by the BlackBerry port. > Source/cmakeconfig.h.cmake:-53 > -#cmakedefine01 ENABLE_OVERFLOW_SCROLLING Ditto.

Rob Buis

Comment 9 2012-04-10 10:39:38 PDT

Comment on attachment 136486 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136486&action=review >>> Source/cmakeconfig.h.cmake:-26 >>> -#cmakedefine01 ENABLE_FIXED_REPORTED_SIZE >> >> This is used by the BlackBerry port. > > This is used by the BlackBerry port. (Added in changeset 112654; <http://trac.webkit.org/changeset/112654/trunk/Source/cmakeconfig.h.cmake>) This is used by the BlackBerry port. >>> Source/cmakeconfig.h.cmake:-53 >>> -#cmakedefine01 ENABLE_OVERFLOW_SCROLLING >> >> Ditto. > > Ditto. Ditto.

Patrick R. Gansterer

Comment 10 2012-04-10 10:41:34 PDT

hmm, i grep'ed the features i removed: e.g "grep -r ENABLE\(CLIENT_BASED ." does not give any results (expect ChangeLog ;-)) in the Source directory. Is there a way how i can check the needed features?

Patrick R. Gansterer

Comment 11 2012-04-10 10:45:48 PDT

What about adding them again, when needed? E.g. CLIENT_BASED_GEOLOCATION has been removed in http://trac.webkit.org/changeset/110595, so you need to change your not upstreamed files anyway to match trunk?

Rob Buis

Comment 12 2012-04-10 10:47:10 PDT

Hi Patrick, (In reply to comment #11) > What about adding them again, when needed? > E.g. CLIENT_BASED_GEOLOCATION has been removed in http://trac.webkit.org/changeset/110595, so you need to change your not upstreamed files anyway to match trunk? Jeff Rogers replied on the thread in webkit-dev, you can remove CLIENT_BASED_GEOLOCATION define from BlackBerry point of view.

Gyuyoung Kim

Comment 13 2012-04-10 11:17:04 PDT

Comment on attachment 136477 [details] Patch Attachment 136477 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/12344031

Gyuyoung Kim

Comment 14 2012-04-10 12:25:19 PDT

Comment on attachment 136486 [details] Patch Attachment 136486 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/12379574

Csaba Osztrogonác

Comment 15 2015-02-26 07:08:12 PST

It is invalid long long time ago.

Note You need to log in before you can comment on or make changes to this bug.