Summary: | webkit-patch upload --suggest-reviewers shouldn't break in the presence of deleted or moved files | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ami Fischman <fischman> | ||||
Component: | Tools / Tests | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, darin, dbates, ddkilzer, glenn, mcatanzaro, rniwa, youennf | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=160302 | ||||||
Attachments: |
|
Description
Ami Fischman
2012-04-05 18:27:33 PDT
Created attachment 284804 [details]
Patch v1
Attachment 284804 [details] did not pass style-queue:
ERROR: Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:413: [SCMTest._shared_test_revisions_changing_file] Instance of 'SCMTest' has no 'scm' member [pylint/E1101] [5]
Total errors found: 1 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #2) > Attachment 284804 [details] did not pass style-queue: > > ERROR: Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:413: > [SCMTest._shared_test_revisions_changing_file] Instance of 'SCMTest' has no > 'scm' member [pylint/E1101] [5] > Total errors found: 1 in 4 files This can be safely ignored. Tests pass despite this warning. Comment on attachment 284804 [details] Patch v1 Clearing flags on attachment: 284804 Committed r203832: <http://trac.webkit.org/changeset/203832> All reviewed patches have been landed. Closing bug. |