Summary: | Replace further usage of int with CSSPropertyID. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Luke Macpherson <macpherson> | ||||||
Component: | New Bugs | Assignee: | Luke Macpherson <macpherson> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | kling, macpherson, menard, simon.fraser, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Luke Macpherson
2012-04-03 22:36:47 PDT
Created attachment 135516 [details]
Patch
This was a git rebase of my own CSSPropertyID removal, which coincidentally I was working on at the same time as Alexis. There were a few more cases I fixed which you can find in this patch. Also, it re-adds some variable names which were removed by Alexis' recent patches (because those variable names add useful meaning to int / bool etc.). (In reply to comment #2) > This was a git rebase of my own CSSPropertyID removal, which coincidentally I was working on at the same time as Alexis. There were a few more cases I fixed which you can find in this patch. > > Also, it re-adds some variable names which were removed by Alexis' recent patches (because those variable names add useful meaning to int / bool etc.). https://bugs.webkit.org/show_bug.cgi?id=83151 added them back all like before. Would you mind uploading again your patch with the CSSPropertyID changes only. Thanks. Comment on attachment 135516 [details] Patch AnimationBase has also some HashMap that could be changed (e.g. animatableShorthandsAffectingProperty). (when https://bugs.webkit.org/show_bug.cgi?id=83050 will land). StylePropertySet::removePropertiesInSet could be changed. KeyFrameList also could be changed. HashSet<int> m_pendingImageProperties; // Hash of CSSPropertyIDs in CSSStyleSelector can also be ported. Comment on attachment 135516 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135516&action=review > Source/WebCore/css/makeprop.pl:199 > +inline CSSPropertyID convertToCSSPropertyID(int value) This can be remove after https://bugs.webkit.org/show_bug.cgi?id=83050. You may want to check you this https://bugs.webkit.org/show_bug.cgi?id=83224 (In reply to comment #3) > (In reply to comment #2) > > This was a git rebase of my own CSSPropertyID removal, which coincidentally I was working on at the same time as Alexis. There were a few more cases I fixed which you can find in this patch. > > > > Also, it re-adds some variable names which were removed by Alexis' recent patches (because those variable names add useful meaning to int / bool etc.). > > https://bugs.webkit.org/show_bug.cgi?id=83151 added them back all like before. Would you mind uploading again your patch with the CSSPropertyID changes only. > > Thanks. Great. I figured that part of the patch would go away with a rebase. Thanks for adding them back. Created attachment 135718 [details]
Patch
Comment on attachment 135718 [details] Patch Clearing flags on attachment: 135718 Committed r113273: <http://trac.webkit.org/changeset/113273> All reviewed patches have been landed. Closing bug. |