Bug 83119

Summary: Replace further usage of int with CSSPropertyID.
Product: WebKit Reporter: Luke Macpherson <macpherson>
Component: New BugsAssignee: Luke Macpherson <macpherson>
Status: RESOLVED FIXED    
Severity: Normal CC: kling, macpherson, menard, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Luke Macpherson
Reported 2012-04-03 22:36:47 PDT
Replace further usage of int with CSSPropertyID.
Attachments
Patch (18.34 KB, patch)
2012-04-03 22:38 PDT, Luke Macpherson 		no flags
DetailsFormatted DiffDiff
Patch (9.82 KB, patch)
2012-04-04 16:34 PDT, Luke Macpherson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Luke Macpherson
Comment 1 2012-04-03 22:38:42 PDT
Created attachment 135516 [details] Patch
Luke Macpherson
Comment 2 2012-04-03 22:42:16 PDT
This was a git rebase of my own CSSPropertyID removal, which coincidentally I was working on at the same time as Alexis. There were a few more cases I fixed which you can find in this patch. Also, it re-adds some variable names which were removed by Alexis' recent patches (because those variable names add useful meaning to int / bool etc.).
Alexis Menard (darktears)
Comment 3 2012-04-04 06:38:17 PDT
(In reply to comment #2) > This was a git rebase of my own CSSPropertyID removal, which coincidentally I was working on at the same time as Alexis. There were a few more cases I fixed which you can find in this patch. > > Also, it re-adds some variable names which were removed by Alexis' recent patches (because those variable names add useful meaning to int / bool etc.). https://bugs.webkit.org/show_bug.cgi?id=83151 added them back all like before. Would you mind uploading again your patch with the CSSPropertyID changes only. Thanks.
Alexis Menard (darktears)
Comment 4 2012-04-04 06:46:45 PDT
Comment on attachment 135516 [details] Patch AnimationBase has also some HashMap that could be changed (e.g. animatableShorthandsAffectingProperty). (when https://bugs.webkit.org/show_bug.cgi?id=83050 will land). StylePropertySet::removePropertiesInSet could be changed. KeyFrameList also could be changed. HashSet<int> m_pendingImageProperties; // Hash of CSSPropertyIDs in CSSStyleSelector can also be ported.
Alexis Menard (darktears)
Comment 5 2012-04-04 06:54:09 PDT
Comment on attachment 135516 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135516&action=review > Source/WebCore/css/makeprop.pl:199 > +inline CSSPropertyID convertToCSSPropertyID(int value) This can be remove after https://bugs.webkit.org/show_bug.cgi?id=83050.
Alexis Menard (darktears)
Comment 6 2012-04-04 15:07:31 PDT
You may want to check you this https://bugs.webkit.org/show_bug.cgi?id=83224
Luke Macpherson
Comment 7 2012-04-04 15:23:22 PDT
(In reply to comment #3) > (In reply to comment #2) > > This was a git rebase of my own CSSPropertyID removal, which coincidentally I was working on at the same time as Alexis. There were a few more cases I fixed which you can find in this patch. > > > > Also, it re-adds some variable names which were removed by Alexis' recent patches (because those variable names add useful meaning to int / bool etc.). > > https://bugs.webkit.org/show_bug.cgi?id=83151 added them back all like before. Would you mind uploading again your patch with the CSSPropertyID changes only. > > Thanks. Great. I figured that part of the patch would go away with a rebase. Thanks for adding them back.
Luke Macpherson
Comment 8 2012-04-04 16:34:57 PDT
Created attachment 135718 [details] Patch
WebKit Review Bot
Comment 9 2012-04-04 18:42:24 PDT
Comment on attachment 135718 [details] Patch Clearing flags on attachment: 135718 Committed r113273: <http://trac.webkit.org/changeset/113273>
WebKit Review Bot
Comment 10 2012-04-04 18:42:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.